[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-usability
Subject: Re: [KDE Usability] Review Request 127484: applet: Add streams tab to manage applications volume
From: David Rosca <nowrep () gmail ! com>
Date: 2016-03-24 15:00:18
Message-ID: 20160324150018.21226.33938 () mimi ! kde ! org
[Download RAW message or body]
--===============5098801705947057130==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 24, 2016, 2:53 p.m., Kai Uwe Broulik wrote:
> > src/pulseaudio.h, line 100
> > <https://git.reviewboard.kde.org/r/127484/diff/2/?file=453889#file453889line100>
> >
> > You don't actually use the sources, rather have a "count" property?
I copied it from SinkModel::sinks(), just for the consistency. In this case only the \
count is used, but I think it doesn't hurt (as the model doesn't really changes \
often) and may be useful in future?
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127484/#review93930
-----------------------------------------------------------
On March 24, 2016, 2:28 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127484/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 2:28 p.m.)
>
>
> Review request for Plasma and KDE Usability.
>
>
> Repository: plasma-pa
>
>
> Description
> -------
>
> Applet now have two tabs: Devices and Streams.
> If there are more audo devices, streams can be moved between them with combobox \
> that is visible after clicking on stream item.
> BUG: 352042
> BUG: 353232
>
>
> Diffs
> -----
>
> applet/contents/ui/ListItemBase.qml 2e31eeb
> applet/contents/ui/SinkInputListItem.qml 3867007
> applet/contents/ui/SourceOutputListItem.qml 3b684fc
> applet/contents/ui/StreamListItemBase.qml 7c0af12
> applet/contents/ui/main.qml bf6f683
> src/pulseaudio.h 9fc9656
> src/pulseaudio.cpp 1488784
>
> Diff: https://git.reviewboard.kde.org/r/127484/diff/
>
>
> Testing
> -------
>
> Everything seems to work fine.
>
>
> File Attachments
> ----------------
>
> applet-devices.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/d1f444cd-c69b-4888-a0c0-24bc4b6b8904__applet-devices.png
> applet-streams.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/30a3cdfb-b6b5-41c7-bb15-37c6b87604a4__applet-streams.png
> applet-streams-more-devices.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/82f0eb13-95a5-4d0c-b50b-682cf7c3b384__applet-streams-more-devices.png
> applet-streams-more-devices.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/b2dafc91-4bde-42dc-bfd5-036ee001b984__applet-streams-more-devices.png
>
>
> Thanks,
>
> David Rosca
>
>
--===============5098801705947057130==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127484/">https://git.reviewboard.kde.org/r/127484/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 24th, 2016, 2:53 p.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127484/diff/2/?file=453889#file453889line100" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/pulseaudio.h</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">100</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Q_PROPERTY</span><span class="p">(</span><span class="n">QList</span><span \
class="o"><</span><span class="n">QObject</span> <span class="o">*></span> \
<span class="n">sources</span> <span class="n">READ</span> <span \
class="n">sources</span> <span class="n">NOTIFY</span> <span \
class="n">sourcesChanged</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
don't actually use the sources, rather have a "count" property?</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I copied it from SinkModel::sinks(), just for the consistency. In this case \
only the count is used, but I think it doesn't hurt (as the model doesn't really \
changes often) and may be useful in future?</p></pre> <br />
<p>- David</p>
<br />
<p>On March 24th, 2016, 2:28 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated March 24, 2016, 2:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-pa
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Applet now have two tabs: Devices and Streams. If \
there are more audo devices, streams can be moved between them with combobox that is \
visible after clicking on stream item.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: \
352042
BUG: 353232</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Everything seems to work fine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applet/contents/ui/ListItemBase.qml <span style="color: \
grey">(2e31eeb)</span></li>
<li>applet/contents/ui/SinkInputListItem.qml <span style="color: \
grey">(3867007)</span></li>
<li>applet/contents/ui/SourceOutputListItem.qml <span style="color: \
grey">(3b684fc)</span></li>
<li>applet/contents/ui/StreamListItemBase.qml <span style="color: \
grey">(7c0af12)</span></li>
<li>applet/contents/ui/main.qml <span style="color: grey">(bf6f683)</span></li>
<li>src/pulseaudio.h <span style="color: grey">(9fc9656)</span></li>
<li>src/pulseaudio.cpp <span style="color: grey">(1488784)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127484/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/d1f444cd-c69b-4888-a0c0-24bc4b6b8904__applet-devices.png">applet-devices.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/30a3cdfb-b6b5-41c7-bb15-37c6b87604a4__applet-streams.png">applet-streams.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/82f0eb13 \
-95a5-4d0c-b50b-682cf7c3b384__applet-streams-more-devices.png">applet-streams-more-devices.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/b2dafc91 \
-4bde-42dc-bfd5-036ee001b984__applet-streams-more-devices.png">applet-streams-more-devices.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5098801705947057130==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic