[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-usability
Subject: Re: [KDE Usability] Review Request 127054: Add a Filter Toolbar Button for Dolphin
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2016-03-14 0:23:28
Message-ID: 20160314002328.22520.80240 () mimi ! kde ! org
[Download RAW message or body]
--===============8482317726032340963==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On März 12, 2016, 11:10 nachm., Thomas Lübking wrote:
> > dolphinmainwindow.cpp, line 1092
> > <https://git.reviewboard.kde.org/r/127054/diff/4/?file=449843#file449843line1092>
> >
> > What exactly was the problem with
> >
> > QAction *showFilterBar ...;
> > showFilterBar->setCheckable(true);
> > ?
>
> arnav dhamija wrote:
> Right. So the problem with the QAction is that it doesn't have a "Pressed" state \
> when the Filter button has been toggled. QPushButton probably would support do it \
> but the rest of the Toggle buttons in the Dolphin Toolbar also use a KToggleAction \
> (eg the Preview button) so I felt this approach makes more sense.
> arnav dhamija wrote:
> In the latest commit, I have usedcreated a checkable QAction to replace the \
> KToggleAction which was causing Dolphin to crash when the Split view was opened. \
> The reason for this is unclear, but QAction seems to be much more stable.
The crash cause will have been the toggled signal which is prone to cause recursions \
when bound to slots which, well, toggle the action ;-)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127054/#review93458
-----------------------------------------------------------
On März 13, 2016, 11:48 nachm., arnav dhamija wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127054/
> -----------------------------------------------------------
>
> (Updated März 13, 2016, 11:48 nachm.)
>
>
> Review request for Dolphin, KDE Usability and Emmanuel Pescosta.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> This patch was created to implement the feature suggested here: \
> [https://todo.kde.org/?controller=task&action=show&task_id=966](https://todo.kde.org/?controller=task&action=show&task_id=966)
>
> This patch adds a Filter Button to the toolbar of Dolphin. This button can be \
> toggled to show/hide the Filter Bar.
> In this patch, one might notice that there is now show_filter_bar and \
> show_filter_bar_button in dolphinui.rc file. This was done because I found that \
> using the same action for the menu entry and the toolbar entry would cause \
> something to break (eg, shortcuts would stop working).
> A screenshot of the toolbar is also attached.
>
>
> Diffs
> -----
>
> dolphinmainwindow.h 7003e94
> dolphinmainwindow.cpp f7a7613
>
> Diff: https://git.reviewboard.kde.org/r/127054/diff/
>
>
> Testing
> -------
>
> manual
>
>
> File Attachments
> ----------------
>
> dolphintoolbar.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/12/d936e5d0-557c-45c5-9a2d-f849e5d284a6__dolphintoolbar.png
>
>
> Thanks,
>
> arnav dhamija
>
>
--===============8482317726032340963==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127054/">https://git.reviewboard.kde.org/r/127054/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On März 12th, 2016, 11:10 nachm. UTC, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127054/diff/4/?file=449843#file449843line1092" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dolphinmainwindow.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1091</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span \
class="hl">Q</span>Action</span><span class="o">*</span> <span \
class="n">showFilterBar</span> <span class="o">=</span> <span \
class="n">actionCollection</span><span class="p">()</span><span \
class="o">-></span><span class="n">addAction</span><span class="p">(</span><span \
class="s">"show_filter_bar"</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1086</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n"><span class="hl">KToggle</span>Action</span><span class="o">*</span> <span \
class="n">showFilterBar</span> <span class="o">=</span> <span \
class="n">actionCollection</span><span class="p">()</span><span \
class="o">-></span><span class="n">add</span><span class="o"><span \
class="hl"><</span></span><span class="n"><span \
class="hl">KToggle</span>Action</span><span class="o"><span \
class="hl">></span></span><span class="p">(</span><span \
class="s">"show_filter_bar"</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What exactly was the \
problem with
QAction *showFilterBar ...;
showFilterBar->setCheckable(true);
?</pre>
</blockquote>
<p>On März 13th, 2016, 8:41 vorm. UTC, <b>arnav dhamija</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Right. So the problem with the QAction is that it doesn't have a "Pressed" \
state when the Filter button has been toggled. QPushButton probably would support do \
it but the rest of the Toggle buttons in the Dolphin Toolbar also use a KToggleAction \
(eg the Preview button) so I felt this approach makes more sense.</p></pre> \
</blockquote>
<p>On März 13th, 2016, 9:53 vorm. UTC, <b>arnav dhamija</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In \
the latest commit, I have usedcreated a checkable QAction to replace the \
KToggleAction which was causing Dolphin to crash when the Split view was opened. The \
reason for this is unclear, but QAction seems to be much more stable.</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The crash cause will have been the toggled signal which is prone to cause \
recursions when bound to slots which, well, toggle the action ;-)</p></pre> <br />
<p>- Thomas</p>
<br />
<p>On März 13th, 2016, 11:48 nachm. UTC, arnav dhamija wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin, KDE Usability and Emmanuel Pescosta.</div>
<div>By arnav dhamija.</div>
<p style="color: grey;"><i>Updated März 13, 2016, 11:48 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch was created to implement the feature \
suggested here: <a href="https://todo.kde.org/?controller=task&action=show&task_id=966" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">https://todo.kde.org/?controller=task&action=show&task_id=966</a></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch adds a Filter Button to the toolbar of \
Dolphin. This button can be toggled to show/hide the Filter Bar.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">In this patch, one might notice that there is now show_filter_bar and \
show_filter_bar_button in dolphinui.rc file. This was done because I found that using \
the same action for the menu entry and the toolbar entry would cause something to \
break (eg, shortcuts would stop working). </p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">A screenshot of the \
toolbar is also attached.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">manual</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphinmainwindow.h <span style="color: grey">(7003e94)</span></li>
<li>dolphinmainwindow.cpp <span style="color: grey">(f7a7613)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127054/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/12/d936e5d0-557c-45c5-9a2d-f849e5d284a6__dolphintoolbar.png">dolphintoolbar.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8482317726032340963==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic