[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-usability
Subject: Re: [KDE Usability] Review Request 126467: Add Case Sensitive Sorting to Dolphin
From: Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date: 2016-01-28 21:07:00
Message-ID: 20160128210700.17778.60392 () mimi ! kde ! org
[Download RAW message or body]
--===============6257822370571672598==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126467/#review91721
-----------------------------------------------------------
Ship it!
Nice work, thanks! :)
Do you have git access or should I push it on your behalf?
- Emmanuel Pescosta
On Jan. 23, 2016, 8:57 p.m., arnav dhamija wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126467/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2016, 8:57 p.m.)
>
>
> Review request for Dolphin, KDE Usability and Emmanuel Pescosta.
>
>
> Bugs: 148550
> https://bugs.kde.org/show_bug.cgi?id=148550
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> See also: https://git.reviewboard.kde.org/r/112330/
>
> This patch was redone because of the transition to KF5.
>
> This patch adds an option for case sensitive sorting in Dolphin under General \
> Settings by updating the Case Sensitivity of the QCollator in kfileitemmodel.cpp as \
> with the user's selection. Much of what I have done has been based off the code for \
> the Natural Sorting option.
> However I have made a few observations of the results:
> 1) Toggling the Natural Sorting or the Case Sensitive Sorting checkbox in General \
> Settings will not update the sorting of the files in a directory until Dolphin is \
> restarted (I guess this is a bug?). 2) If Natural Sorting AND Case Sensitive \
> Sorting are enabled together, Dolphin will sort the files in Natural Sorting using \
> Case Insensitive mode. This is probably a bug on my part - so I would be glad to \
> have a more experienced programmer take a look at it.
> After some feedback from the usability team, I have changed the GUI of the sorting \
> options menu a bit:
> <RadioButton>Enable Extra Sorting Features
> <RadioButton>Natural Sorting
> <RadioButton>Case Sensitive Sorting
>
> An example of this can be seen in the screenshot attached with this review request.
>
> EDIT: it was suggested in the comments to use 3 radio buttons for the sorting \
> options as all 3 are mutually exclusive. This change is reflected in the 2nd \
> screenshot (on Unity Ubuntu 15.10). Finally, I used an Enum to switch between the 3 \
> sorting modes and updated the KConfig file accordingly.
> EDIT2: Bumping this for another review and whether it is ready to be shipped.
>
>
> Diffs
> -----
>
> kitemviews/kfileitemmodel.h 167f508
> kitemviews/kfileitemmodel.cpp 5f6fed0
> settings/dolphin_generalsettings.kcfg 9ff14d1
> settings/general/behaviorsettingspage.h 6e49169
> settings/general/behaviorsettingspage.cpp 093a1f4
>
> Diff: https://git.reviewboard.kde.org/r/126467/diff/
>
>
> Testing
> -------
>
> manual
>
>
> File Attachments
> ----------------
>
> Idea for Dolphin General Settings behavior tab
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/23/d8e9eab1-1c9e-4cac-84e6-11ad10c077e9__dolphin_settings.png
> Screenshot from 2015-12-23 22-21-24.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/23/a04136b1-b7fa-45c4-a2ec-a8d8fd3e8625__Screenshot_from_2015-12-23_22-21-24.png
>
>
> Thanks,
>
> arnav dhamija
>
>
--===============6257822370571672598==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126467/">https://git.reviewboard.kde.org/r/126467/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice work, thanks! :)
Do you have git access or should I push it on your behalf?</pre>
<br />
<p>- Emmanuel Pescosta</p>
<br />
<p>On January 23rd, 2016, 8:57 p.m. CET, arnav dhamija wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin, KDE Usability and Emmanuel Pescosta.</div>
<div>By arnav dhamija.</div>
<p style="color: grey;"><i>Updated Jan. 23, 2016, 8:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=148550">148550</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See also: \
https://git.reviewboard.kde.org/r/112330/</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch was redone \
because of the transition to KF5.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds an \
option for case sensitive sorting in Dolphin under General Settings by updating the \
Case Sensitivity of the QCollator in kfileitemmodel.cpp as with the user's selection. \
Much of what I have done has been based off the code for the Natural Sorting \
option.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">However I have made a few observations of the results: \
1) Toggling the Natural Sorting or the Case Sensitive Sorting checkbox in General \
Settings will not update the sorting of the files in a directory until Dolphin is \
restarted (I guess this is a bug?). 2) If Natural Sorting AND Case Sensitive Sorting \
are enabled together, Dolphin will sort the files in Natural Sorting using Case \
Insensitive mode. This is probably a bug on my part - so I would be glad to have a \
more experienced programmer take a look at it.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">After \
some feedback from the usability team, I have changed the GUI of the sorting options \
menu a bit:</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><RadioButton>Enable Extra Sorting Features \
<RadioButton>Natural Sorting <RadioButton>Case Sensitive Sorting</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">An example of this can be seen in the screenshot \
attached with this review request.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">EDIT: it was suggested \
in the comments to use 3 radio buttons for the sorting options as all 3 are mutually \
exclusive. This change is reflected in the 2nd screenshot (on Unity Ubuntu 15.10). \
Finally, I used an Enum to switch between the 3 sorting modes and updated the KConfig \
file accordingly.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">EDIT2: Bumping this for another review \
and whether it is ready to be shipped.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">manual</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kitemviews/kfileitemmodel.h <span style="color: grey">(167f508)</span></li>
<li>kitemviews/kfileitemmodel.cpp <span style="color: grey">(5f6fed0)</span></li>
<li>settings/dolphin_generalsettings.kcfg <span style="color: \
grey">(9ff14d1)</span></li>
<li>settings/general/behaviorsettingspage.h <span style="color: \
grey">(6e49169)</span></li>
<li>settings/general/behaviorsettingspage.cpp <span style="color: \
grey">(093a1f4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126467/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/23/d8e9eab1-1c9e-4cac-84e6-11ad10c077e9__dolphin_settings.png">Idea \
for Dolphin General Settings behavior tab</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/23/a04136b1 \
-b7fa-45c4-a2ec-a8d8fd3e8625__Screenshot_from_2015-12-23_22-21-24.png">Screenshot \
from 2015-12-23 22-21-24.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6257822370571672598==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic