[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-usability
Subject: Re: [KDE Usability] Review Request 126300: Plasma Search KCM: display the runner descriptions
From: "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date: 2016-01-10 16:33:21
Message-ID: 20160110163321.23702.78879 () mimi ! kde ! org
[Download RAW message or body]
--===============1954712002442371106==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126300/
-----------------------------------------------------------
(Updated Jan. 10, 2016, 4:33 p.m.)
Review request for Plasma and KDE Usability.
Changes
-------
Long description lines elided with "..." instead of simply truncated, screenshot \
updated.
Not sure if it's possible to show a tool tip only if the description is truncated, \
since the width calculation is done while painting in the item delegate but the tool \
tip would have to be set when the items are statically created in \
SearchConfigModule::load(). So the options would be to have either no tool tip, or a \
tool tip for everything even if the text is not truncated. Since the "Control Audio \
Player" example seems to be the only one that gets truncated in a standard Plasma5 \
install with the standard dialogue and font sizes, I'm not sure it is worth \
addressing.
Repository: plasma-desktop
Description
-------
In Plasma 5 this KCM only lists the names of the available runners, with no \
explanation of what they do. In its previous incarnation in KDE4 (the dropdown list \
from the runner config button), the descriptions were displayed. This change \
restores them.
Diffs (updated)
-----
kcms/runners/kcm.h f1239ee
kcms/runners/kcm.cpp 4af82de
Diff: https://git.reviewboard.kde.org/r/126300/diff/
Testing
-------
Built plasma-desktop with this change, checked appearance of KCM in Breeze, Oxygen \
and older styles.
File Attachments (updated)
----------------
Screenshot before
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png
Screenshot after
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png
Long lines elided
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/193898fa-d860-4263-b2c1-e060a89522dc__plasmasearch-elided-r126303.png
Thanks,
Jonathan Marten
--===============1954712002442371106==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126300/">https://git.reviewboard.kde.org/r/126300/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2016, 4:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Long description lines elided with "..." instead of simply \
truncated, screenshot updated.
Not sure if it's possible to show a tool tip only if the description is \
truncated, since the width calculation is done while painting in the item delegate \
but the tool tip would have to be set when the items are statically created in \
SearchConfigModule::load(). So the options would be to have either no tool tip, or a \
tool tip for everything even if the text is not truncated. Since the "Control \
Audio Player" example seems to be the only one that gets truncated in a standard \
Plasma5 install with the standard dialogue and font sizes, I'm not sure it is \
worth addressing.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In Plasma 5 this KCM only lists the names of the \
available runners, with no explanation of what they do. In its previous incarnation \
in KDE4 (the dropdown list from the runner config button), the descriptions were \
displayed. This change restores them.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built plasma-desktop with this change, checked \
appearance of KCM in Breeze, Oxygen and older styles.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/runners/kcm.h <span style="color: grey">(f1239ee)</span></li>
<li>kcms/runners/kcm.cpp <span style="color: grey">(4af82de)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126300/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png">Screenshot \
before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png">Screenshot \
after</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/193898fa-d860-4263-b2c1-e060a89522dc__plasmasearch-elided-r126303.png">Long \
lines elided</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1954712002442371106==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic