[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    Re: [KDE Usability] Review Request 126591: [Task Manager] Adjust ToolTip when no thumbnail is availa
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2016-01-07 16:32:19
Message-ID: 20160107163219.6499.26939 () mimi ! kde ! org
[Download RAW message or body]

--===============2360284292158079708==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126591/
-----------------------------------------------------------

(Updated Jan. 7, 2016, 4:32 nachm.)


Status
------

This change has been discarded.


Review request for Plasma, KDE Usability and Eike Hein.


Bugs: 332003
    https://bugs.kde.org/show_bug.cgi?id=332003


Repository: plasma-desktop


Description
-------

When no window thumbnail is available, the tooltip will be hidden. In case of \
multiple thumbnails (grouping) the thumbnail fallback will be still shown to ensure a \
unified look and allow closing individual windows in a group through the tooltip.

I could not just visible: thumbnailAvailable the preview as then it will disable \
itself and never attempt again to grab a thumbnail.


Diffs
-----

  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 972dd62 

Diff: https://git.reviewboard.kde.org/r/126591/diff/


Testing
-------

Works.


File Attachments
----------------

single window
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/01/f0b63d68-b3e1-44dd-b4d2-43b164de7954__tooltipwithsingle.jpg
 multiple windows (one without preview)
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/01/e775eab1-9fe3-4f9a-bc18-4db75d36cca2__tooltipwithmultiple.jpg



Thanks,

Kai Uwe Broulik


--===============2360284292158079708==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126591/">https://git.reviewboard.kde.org/r/126591/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, KDE Usability and Eike Hein.</div>
<div>By Kai Uwe Broulik.</div>


<p style="color: grey;"><i>Updated Jan. 7, 2016, 4:32 nachm.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=332003">332003</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When no window thumbnail is available, the tooltip \
will be hidden. In case of multiple thumbnails (grouping) the thumbnail fallback will \
be still shown to ensure a unified look and allow closing individual windows in a \
group through the tooltip.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I could not just visible: \
thumbnailAvailable the preview as then it will disable itself and never attempt again \
to grab a thumbnail.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/taskmanager/package/contents/ui/ToolTipDelegate.qml <span style="color: \
grey">(972dd62)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126591/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/01/f0b63d68-b3e1-44dd-b4d2-43b164de7954__tooltipwithsingle.jpg">single \
window</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/01/e775eab1-9fe3-4f9a-bc18-4db75d36cca2__tooltipwithmultiple.jpg">multiple \
windows (one without preview)</a></li>

</ul>




  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============2360284292158079708==--


[Attachment #3 (text/plain)]

_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic