[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-usability
Subject: Re: [KDE Usability] Review Request 126505: Do not show a warning color before the user even started
From: "David Faure" <faure () kde ! org>
Date: 2016-01-02 11:33:26
Message-ID: 20160102113326.30660.35297 () mimi ! kde ! org
[Download RAW message or body]
--===============2782266879124754043==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126505/#review90441
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Dec. 27, 2015, 2:40 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126505/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2015, 2:40 p.m.)
>
>
> Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David Faure.
>
>
> Repository: kwidgetsaddons
>
>
> Description
> -------
>
> As discussed in RR 125619 and 126426, the password verification field (in a \
> KNewPasswordWidget) should not be marked as "wrong" before the user even started \
> typing the verification password.
> The revised approach is the following:
>
> * The user starts typing something as password, e.g. 1234
> * The user types something else as verification password
> * As soon as the verification is not anymore a prefix of the password (e.g. \
> verification = 122), the warning color is shown.
> * As soon as the verification is a prefix again (e.g. the user deletes the second \
> 2, i.e. verification = 12) the warning color is not shown anymore.
>
> Diffs
> -----
>
> autotests/knewpasswordwidgettest.h 43845128adec01aced4353c9f7986b7977829a2a
> autotests/knewpasswordwidgettest.cpp 297b88d5f18b9cd37f0d26d94e56f38870756f20
> src/knewpasswordwidget.cpp a1b59454a2c2d7c09ac32acec52d3fffa73f77fc
>
> Diff: https://git.reviewboard.kde.org/r/126505/diff/
>
>
> Testing
> -------
>
> Autotests assert what described above. Gif pictures would explain the patch better \
> than 1000 words, but I suck at creating them :(
>
> Thanks,
>
> Elvis Angelaccio
>
>
--===============2782266879124754043==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126505/">https://git.reviewboard.kde.org/r/126505/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- David Faure</p>
<br />
<p>On December 27th, 2015, 2:40 p.m. UTC, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David \
Faure.</div> <div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2015, 2:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As discussed in RR 125619 and 126426, the password \
verification field (in a KNewPasswordWidget) should not be marked as "wrong" before \
the user even started typing the verification password.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
revised approach is the following:</p> <ul style="padding: 0;text-rendering: \
inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;"> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">The user starts typing something as password, e.g. 1234</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">The user types something else as verification password</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">As soon as the verification is not anymore a prefix of the password (e.g. \
verification = 122), the warning color is shown.</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">As \
soon as the verification is a prefix again (e.g. the user deletes the second 2, i.e. \
verification = 12) the warning color is not shown anymore.</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Autotests assert what described above. Gif pictures \
would explain the patch better than 1000 words, but I suck at creating them \
:(</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/knewpasswordwidgettest.h <span style="color: \
grey">(43845128adec01aced4353c9f7986b7977829a2a)</span></li>
<li>autotests/knewpasswordwidgettest.cpp <span style="color: \
grey">(297b88d5f18b9cd37f0d26d94e56f38870756f20)</span></li>
<li>src/knewpasswordwidget.cpp <span style="color: \
grey">(a1b59454a2c2d7c09ac32acec52d3fffa73f77fc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126505/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2782266879124754043==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic