[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-usability
Subject: Re: [KDE Usability] Review Request 125094: Adding icon to show hidden files
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2015-12-29 9:46:39
Message-ID: 20151229094639.18086.93664 () mimi ! kde ! org
[Download RAW message or body]
--===============3300600815295970920==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125094/#review90273
-----------------------------------------------------------
src/views/dolphinviewactionhandler.cpp (line 484)
<https://git.reviewboard.kde.org/r/125094/#comment61787>
Please use the conditional operator to get the right string (shown ? "visibility" \
: "hint")
- Emmanuel Pescosta
On Dec. 26, 2015, 12:25 p.m., Roman Gilg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125094/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2015, 12:25 p.m.)
>
>
> Review request for Dolphin and KDE Usability.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> Icon based on 'edit-copy.svg'. Sorry, didn't know how to add the additionally \
> breeze repository for the svg-files. First review request. Be nice please. :)
>
>
> Diffs
> -----
>
> src/views/dolphinviewactionhandler.cpp ac538a6
>
> Diff: https://git.reviewboard.kde.org/r/125094/diff/
>
>
> Testing
> -------
>
> Tested on Arch, Plasma 5.4.
>
>
> File Attachments
> ----------------
>
> hidden-files.svg (16, breeze)
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/b35b6f89-4d89-4434-add7-b38ed2ae0aa1__hidden-files.svg
> hidden-files.svg (22, breeze)
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/a15289c8-9721-40ce-b5ce-0047d5877e08__hidden-files.svg
> hidden-files.svg (16, breeze-dark)
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/8d4c2940-1b3f-43b1-893e-09f49cb6f4aa__hidden-files.svg
> hidden-files.svg (22, breeze-dark)
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/ce296c59-141a-4b50-90bf-d2a1c6e215d0__hidden-files.svg
> Demonstration
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/c731d844-9525-415d-9226-743fea6f5727__change.png
> Revision 3
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/e1b5f750-842f-4aef-b4be-5e96ad3c629f__change2.png
>
>
> Thanks,
>
> Roman Gilg
>
>
--===============3300600815295970920==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125094/">https://git.reviewboard.kde.org/r/125094/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125094/diff/4/?file=426084#file426084line484" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/views/dolphinviewactionhandler.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DolphinViewActionHandler::toggleShowHiddenFiles(bool show)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">484</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">shown</span> <span class="o">?</span> <span \
class="n">showHiddenFilesAction</span><span class="o">-></span><span \
class="n">setIcon</span><span class="p">(</span><span class="n">QIcon</span><span \
class="o">::</span><span class="n">fromTheme</span><span class="p">(</span><span \
class="s">"visibility"</span><span class="p">))</span> <span \
class="o">:</span> <span class="n">showHiddenFilesAction</span><span \
class="o">-></span><span class="n">setIcon</span><span class="p">(</span><span \
class="n">QIcon</span><span class="o">::</span><span class="n">fromTheme</span><span \
class="p">(</span><span class="s">"hint"</span><span \
class="p">));</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please use the conditional operator to get the right string (shown ? \
"visibility" : "hint")</p></pre> </div>
</div>
<br />
<p>- Emmanuel Pescosta</p>
<br />
<p>On December 26th, 2015, 12:25 p.m. CET, Roman Gilg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and KDE Usability.</div>
<div>By Roman Gilg.</div>
<p style="color: grey;"><i>Updated Dec. 26, 2015, 12:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Icon based on 'edit-copy.svg'. Sorry, didn't know how \
to add the additionally breeze repository for the svg-files. First review request. Be \
nice please. :)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested on Arch, Plasma 5.4.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/views/dolphinviewactionhandler.cpp <span style="color: \
grey">(ac538a6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125094/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/b35b6f89-4d89-4434-add7-b38ed2ae0aa1__hidden-files.svg">hidden-files.svg \
(16, breeze)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/a15289c8-9721-40ce-b5ce-0047d5877e08__hidden-files.svg">hidden-files.svg \
(22, breeze)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/8d4c2940-1b3f-43b1-893e-09f49cb6f4aa__hidden-files.svg">hidden-files.svg \
(16, breeze-dark)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/ce296c59-141a-4b50-90bf-d2a1c6e215d0__hidden-files.svg">hidden-files.svg \
(22, breeze-dark)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/c731d844-9525-415d-9226-743fea6f5727__change.png">Demonstration</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/e1b5f750-842f-4aef-b4be-5e96ad3c629f__change2.png">Revision \
3</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3300600815295970920==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic