[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-usability
Subject: Re: [KDE Usability] Review Request 107392: Proposal to add a 'lock toggle button' to filter bar to p
From: "Stuart Citrin" <ctrn3e8 () gmail ! com>
Date: 2013-04-09 15:36:59
Message-ID: 20130409153659.18526.67090 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 5, 2013, 6:06 p.m., Albert Astals Cid wrote:
> > How are we on this? Is anyone reviewing this? Seems it has been forgotten?
>
> Frank Reininghaus wrote:
> It has not been forgotten by me, but it's hard to make progress if nobody else \
> provides feedback concerning Stuart's ideas. I guess we should just merge it before \
> the 4.11 feature freeze and use the "lock" icon if nothing better is available.
Concur with Frank. Suggest just use Diff r7.
- Stuart
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107392/#review30493
-----------------------------------------------------------
On Dec. 31, 2012, 4:30 a.m., Stuart Citrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107392/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2012, 4:30 a.m.)
>
>
> Review request for Dolphin, Oxygen Transparent and KDE Usability.
>
>
> Description
> -------
>
> I wrote a quick add-on for the Dolphin filter bar. It is a button which prevents \
> the filter text from clearing when navigating to a different folder.
> Why this might be needed:
>
> This is an attempt to resolve the following usability conflict:
>
> If one navigates to a different folder, the filter is automatically cleared since \
> one does not want a situation where someone forgets a filter is applied and then \
> doesn't understand why all the files within a folder are not appearing.(current \
> behavior)
> versus:
> A user might want to keep a filter while navigating an arbitrary set of folders, \
> but is unable to, since the filter is automatically cleared upon navigation
> The implementation to try to resolve this conflict is as follows:
>
> 1. A lock filter toggle button is added to the right side of the filter bar.
> 2. If the lock filter button is clicked(on), then if the user navigates away from \
> the current folder, the filter is not cleared. If the lock filter button is \
> released(off), then the text is cleared on navigation...which is the current \
> behavior. 3. A configurable shortcut is added to toggle the lock filter button, \
> with the default being Ctrl-Shift-I (since the default shortcut for hiding and \
> showing the filter bar is Ctrl-I.) 4. If the user toggles the lock filter button \
> to released (off), then the text in the filter also clears. The assumption here is \
> that if the user no longer wants the text to be locked, he probably also wants to \
> clear the text. 5. When the filter bar is hidden, then the lock filter button is \
> released. The next time the filter bar is shown, the lock filter button will be in \
> the released(off) position and the filter text will have been cleared. 6. At \
> application startup, the lock filter button is always off, and the filter bar text \
> cleared.
> This also fixes a current bug in dolphin where one is unable to toggle the \
> visibility of the filter bar using the tool bar filter button, or by using the \
> assigned hot key.
> Note... I think it is 'patch -p2' from the "dolphin" directory (above src directory \
> ) to apply the patch
>
> Diffs
> -----
>
> dolphin/src/dolphinviewcontainer.cpp 26a6803
> dolphin/src/filterbar/filterbar.h 9546c63
> dolphin/src/filterbar/filterbar.cpp f3076f0
>
> Diff: http://git.reviewboard.kde.org/r/107392/diff/
>
>
> Testing
> -------
>
> Went through all paths in dolphin. Tested: 1. Navigate to different folder. Text \
> should clear only when text not locked 2.Ctl-I shortcut to toggle visiblility of \
> filterbar 3.Text clears when filterbar hidden and then shown
> 4. Lock button locks and unlocks text
> 5. Shift-Ctl-I shortcut to toggle lock status of text. Lock button updates \
> appropriately 6. Status (with non-perisistence from previous instance) of lock \
> button when starting application..i.e. lock status is off on startup 7. Change \
> keyboard shortcuts...works appropriately 8. F3 and split view..tabs..etc.. should \
> still work appropriately 9. Monkey tested...cannot get it to crash
> etc....
>
>
> File Attachments
> ----------------
>
> PinPngOxygenIcons.tar
> http://git.reviewboard.kde.org/media/uploaded/files/2012/12/07/PinPngOxygenIcons.tar
>
>
> Screenshots
> -----------
>
> Filter bar with new text locking button
> http://git.reviewboard.kde.org/r/107392/s/877/
> filterbar-w/existing-lock-Icon
> http://git.reviewboard.kde.org/r/107392/s/944/
>
>
> Thanks,
>
> Stuart Citrin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107392/">http://git.reviewboard.kde.org/r/107392/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 5th, 2013, 6:06 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">How are we on this? Is anyone reviewing this? Seems it has been \
forgotten?</pre> </blockquote>
<p>On April 9th, 2013, 6:51 a.m. UTC, <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It has not been \
forgotten by me, but it's hard to make progress if nobody else provides feedback \
concerning Stuart's ideas. I guess we should just merge it before the 4.11 \
feature freeze and use the "lock" icon if nothing better is \
available.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Concur with Frank. \
Suggest just use Diff r7. </pre> <br />
<p>- Stuart</p>
<br />
<p>On December 31st, 2012, 4:30 a.m. UTC, Stuart Citrin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin, Oxygen Transparent and KDE Usability.</div>
<div>By Stuart Citrin.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2012, 4:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I wrote a quick add-on for the Dolphin filter bar. It is a button \
which prevents the filter text from clearing when navigating to a different folder.
Why this might be needed:
This is an attempt to resolve the following usability conflict:
If one navigates to a different folder, the filter is automatically cleared since one \
does not want a situation where someone forgets a filter is applied and then \
doesn't understand why all the files within a folder are not appearing.(current \
behavior)
versus:
A user might want to keep a filter while navigating an arbitrary set of folders, but \
is unable to, since the filter is automatically cleared upon navigation
The implementation to try to resolve this conflict is as follows:
1. A lock filter toggle button is added to the right side of the filter bar.
2. If the lock filter button is clicked(on), then if the user navigates away from the \
current folder, the filter is not cleared. If the lock filter button is \
released(off), then the text is cleared on navigation...which is the current \
behavior. 3. A configurable shortcut is added to toggle the lock filter button, with \
the default being Ctrl-Shift-I (since the default shortcut for hiding and showing the \
filter bar is Ctrl-I.) 4. If the user toggles the lock filter button to released \
(off), then the text in the filter also clears. The assumption here is that if the \
user no longer wants the text to be locked, he probably also wants to clear the text. \
5. When the filter bar is hidden, then the lock filter button is released. The next \
time the filter bar is shown, the lock filter button will be in the released(off) \
position and the filter text will have been cleared. 6. At application startup, the \
lock filter button is always off, and the filter bar text cleared.
This also fixes a current bug in dolphin where one is unable to toggle the visibility \
of the filter bar using the tool bar filter button, or by using the assigned hot key.
Note... I think it is 'patch -p2' from the "dolphin" directory \
(above src directory ) to apply the patch</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Went through all paths in dolphin. Tested: 1. Navigate to different \
folder. Text should clear only when text not locked 2.Ctl-I shortcut to toggle \
visiblility of filterbar 3.Text clears when filterbar hidden and then shown
4. Lock button locks and unlocks text
5. Shift-Ctl-I shortcut to toggle lock status of text. Lock button updates \
appropriately 6. Status (with non-perisistence from previous instance) of lock button \
when starting application..i.e. lock status is off on startup 7. Change keyboard \
shortcuts...works appropriately 8. F3 and split view..tabs..etc.. should still work \
appropriately 9. Monkey tested...cannot get it to crash
etc....</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinviewcontainer.cpp <span style="color: \
grey">(26a6803)</span></li>
<li>dolphin/src/filterbar/filterbar.h <span style="color: \
grey">(9546c63)</span></li>
<li>dolphin/src/filterbar/filterbar.cpp <span style="color: \
grey">(f3076f0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107392/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2012/12/07/PinPngOxygenIcons.tar">PinPngOxygenIcons.tar</a></li>
</ul>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107392/s/877/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/07/FilterBarWithLockingButton_400x100.png" \
style="border: 1px black solid;" alt="Filter bar with new text locking button" /></a>
<a href="http://git.reviewboard.kde.org/r/107392/s/944/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/31/FilterBarWithSystemLockIcon_400x100.png" \
style="border: 1px black solid;" alt="filterbar-w/existing-lock-Icon" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic