[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-usability
Subject: Re: [KDE Usability] Review Request 108504: [High-dpi issues] Fix KIconDialog
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2013-01-20 11:15:59
Message-ID: 20130120111559.4270.5977 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108504/
-----------------------------------------------------------
(Updated Jan. 20, 2013, 11:15 a.m.)
Review request for kdelibs and KDE Usability.
Changes
-------
Stupid Review Board discarded my code comments .. damnit, publish already!
Description
-------
This makes the KIconDialog (the dialog where you can choose icons for eg. folders) \
respect the global icon size. Almost all sizes were hardcoded but the patch does away \
with all of this and works fine with all icon sizes and big font sizes. Also made it \
aware of FontMetrics (atm with bigger fonts, they also get clipped) and adjusts the \
grid height accordingly.
Was fun diving into that "ancient" code :)
Diffs
-----
kio/kfile/kicondialog.cpp b7d646f
Diff: http://git.reviewboard.kde.org/r/108504/diff/
Testing (updated)
-------
Yup, see screenshot.
The only issue that remains is the initial size of the dialog to make it show 4 rows \
of icons. In the current implementation it just adds another 100px to the dialog \
height (cf. line 490), which is easy, if all the sizes are known and fixed, but with \
variing sizes this becomes an issue and I could not think of a proper solution. I \
probably need to add a sizeHint (tried in the private class, didn't help there)? The \
easiest but not neccessarily best solution would be to just set the minimumHeight to \
4 rows and done.
File Attachments
----------------
Icon Dialog with 200dpi
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog.png
Icon Dialog with 200dpi (without patch)
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog2.png
Thanks,
Kai Uwe Broulik
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108504/">http://git.reviewboard.kde.org/r/108504/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2013, 11:15 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Stupid Review Board discarded my code comments .. damnit, publish \
already!</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This makes the KIconDialog (the dialog where you can choose icons for \
eg. folders) respect the global icon size. Almost all sizes were hardcoded but the \
patch does away with all of this and works fine with all icon sizes and big font \
sizes. Also made it aware of FontMetrics (atm with bigger fonts, they also get \
clipped) and adjusts the grid height accordingly.
Was fun diving into that "ancient" code :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yup, see screenshot.
The only issue that remains is the initial size of the dialog to make it show 4 rows \
of icons. In the current implementation it just adds another 100px to the dialog \
height (cf. line 490), which is easy, if all the sizes are known and fixed, but with \
variing sizes this becomes an issue and I could not think of a proper solution. I \
probably need to add a sizeHint (tried in the private class, didn't help there)? \
The easiest but not neccessarily best solution would be to just set the minimumHeight \
to 4 rows and done.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kfile/kicondialog.cpp <span style="color: grey">(b7d646f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108504/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog.png">Icon \
Dialog with 200dpi</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog2.png">Icon \
Dialog with 200dpi (without patch)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic