[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    Re: [KDE Usability] Misuse of toggle buttons, continued
From:       Matt Rogers <mattr () kde ! org>
Date:       2010-08-19 20:17:49
Message-ID: AANLkTi=-xstGJg7UYjuS8HX44MH9EY90kzS2q+gLL1=M () mail ! gmail ! com
[Download RAW message or body]

2010/8/19 Aurélien Gâteau <agateau@kde.org>:
> On 19/08/2010 03:40, Matt Rogers wrote:
>
>>> Right now developers misuse KToggleAction to create actions which change
>>> labels and icons on click. I think there is a need for an action class
>>> which can switch between two sets of labels and icons without being
>>> checkable.
>>>
>>> Example of uses are combined Play/Pause action in media players,
>>> Reload/Stop in web browsers or the Split/Close button in Dolphin (which
>>> does not abuse KToggleAction but probably implements something very
>>> similar to what my class does).
>>>
>>> Aurélien
>>>
>>
>> Why can't we educate developers on how to properly use KToggleAction
>> and/or fix KToggleAction to implement the proper behavior?
>
> I originally thought about going this way, but realize it was not the
> right way: KToggleAction represents a *checkable* action, so it will
> always stay down when clicked. There is no way, as far as I can tell, to
> fix KToggleAction so that one can set an alternative KGuiItem for its
> checked state without making it checkable.
>
> Aurélien

I don't see anything wrong with KToggleAction staying down/being
checked/looking cool in some other way when toggled, as long as the
behavior is as described in the example screenshot you provided on the
wiki. In fact, it looks like the behavior you want can be achieved
with KToggleAction.

While I agree with the text on the wiki for HIG, I'm still not sure
why a new class is needed. What is wrong with the item being checked
that I seem to be missing? Why is the action being checkable a bad
thing (tm)?

Thanks
--
Matt
_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability

[prev in list] [next in list] [prev in thread] [next in thread]