[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    Re: [KDE Usability] Review Request: Add "Open With" actions to
From:       "Harsh J" <qwertymaniac () gmail ! com>
Date:       2010-01-28 21:36:52
Message-ID: 20100128213652.24629.90515 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2757/
-----------------------------------------------------------

(Updated 2010-01-28 21:36:52.695414)


Review request for kdelibs, usability, Shaun Reich, and David Faure.


Changes
-------

Addressed some of dfaure's review comments:

 * Switched from kApplication() to qApp()


Summary
-------

This patch proposes to use KFileItemActions class to add "Open With" actions to the \
context menu of selected file(s) in KDirOperator (which is used by KFileDialog).

Some points on the implementation:
 * Added the action under the KDirOperator::FileActions flag
 * Made openWithActions (a KFileItemActions object) a member of the private KDO class
 * Initialized the same object in setupActions() method

I suppose I must add something to KDirOperator::updatedSelectionDependentActions() \
but I don't think its necessary as the selected items are retrieved while setting up \
this menu itself. Would be better to add a reloader there just in case though. \
Opinions please?

Also, is there a way to make the KDirOperator realize the name of the application \
that's using it? I could use that to block itself out of the suggestions via the \
traderConstraints. Doesn't look possible afaik.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1081124 

Diff: http://reviewboard.kde.org/r/2757/diff


Testing
-------

* Selected no items and right clicked - no submenu/separator shows.
* Selected one item - Open With submenu and sometimes (in cases where only one can \
open)  preferred open with option shows.
* Selected multiple items - Open With submenu and sometimes (in cases where only one \
can open)  preferred open with option shows.
* Repeat above two with directories successfully shows the same.


Screenshots
-----------

Open With actions in KFileDialog
  http://reviewboard.kde.org/r/2757/s/305/


Thanks,

Harsh

_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability


[prev in list] [next in list] [prev in thread] [next in thread]