-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1288/
-----------------------------------------------------------

(Updated 2009-08-12 15:28:12.103167)


Review request for usability and David Jarvie.


Changes
-------

Add David's screen shot.


Summary
-------

Hard-coded colors are Evil (bad Usability, bad Accessibility, and just plain bad... not to mention not very aesthetic in this case IMO). This removes the major hard-coded colors in KAlarm (default alarm colors, colors in the alarm list), the latter of which are especially bad as they can be illegible in some color schemes.

...but there are others in at least eventlistmodel.cpp, messagewin.cpp, dbushandler.cpp and resourcemodelview.cpp. Depending on how motivated I feel, more patches might follow in the future.


Diffs
-----

  /trunk/KDE/kdepim/kalarm/kalarmconfig.kcfg 1010227 

Diff: http://reviewboard.kde.org/r/1288/diff


Testing
-------

built and ran, colors were okay as checked by viewing in Settings, New Alarm, and a disabled alarm.


Screenshots
-----------

David's screen shot
  http://reviewboard.kde.org/r/1288/s/177/


Thanks,

Matthew

_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability