[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    Re: Review Request: --hard_coded_colors in kalarm
From:       "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date:       2009-08-12 0:48:33
Message-ID: 20090812004833.4268.38759 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1288/
-----------------------------------------------------------

(Updated 2009-08-12 00:48:33.394038)


Review request for usability and David Jarvie.


Summary
-------

Hard-coded colors are Evil (bad Usability, bad Accessibility, and just plain bad... \
not to mention not very aesthetic in this case IMO). This removes the major \
hard-coded colors in KAlarm (default alarm colors, colors in the alarm list), the \
latter of which are especially bad as they can be illegible in some color schemes.

...but there are others in at least eventlistmodel.cpp, messagewin.cpp, \
dbushandler.cpp and resourcemodelview.cpp. Depending on how motivated I feel, more \
patches might follow in the future.


Diffs
-----

  /trunk/KDE/kdepim/kalarm/kalarmconfig.kcfg 1010227 

Diff: http://reviewboard.kde.org/r/1288/diff


Testing
-------

built and ran, colors were okay as checked by viewing in Settings, New Alarm, and a \
disabled alarm.


Thanks,

Matthew

_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability


[prev in list] [next in list] [prev in thread] [next in thread]