[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    Re: gtk+ file selector mockups
From:       Mikolaj Machowski <mikmach () wp ! pl>
Date:       2004-01-07 21:30:29
Message-ID: 200401072230.30115.mikmach () wp ! pl
[Download RAW message or body]

Dnia Wednesday 07 of January 2004 13:30, Mikolaj Machowski napisał:
> For icons agree. They are too small. Should be the size of icons in
> toolbar.  But I prefer big icons as default (Fitts law or something like
> that ;)

That was not that hard:

http://skawina.eu.org/mikolaj/bigsmallicons.png

And patches attached.

m.


["kicontheme.diff" (text/x-diff)]

--- kdecore/kicontheme.h.orig	2003-11-03 13:21:33.000000000 +0100
+++ kdecore/kicontheme.h	2004-01-07 17:08:45.000000000 +0100
@@ -87,6 +87,8 @@ public:
     enum StdSizes {
         /// small icons for menu entries
         SizeSmall=16,
+        /// small medium sized icons for panels
+        SizeSmallMedium=22,
         /// medium sized icons for the desktop
         SizeMedium=32,
         /// large sized icons for the panel

["kurlbar.cpp.diff" (text/x-diff)]

--- kio/kfile/kurlbar.cpp.orig	2003-12-07 11:11:27.000000000 +0100
+++ kio/kfile/kurlbar.cpp	2004-01-07 22:06:44.000000000 +0100
@@ -233,8 +233,8 @@ QSize KURLBarItem::sizeHint() const
     const KURLBarListBox *lb =static_cast<const KURLBarListBox*>(listBox());
 
     if ( m_parent->iconSize() < KIcon::SizeMedium ) {
-        wmin = QListBoxPixmap::width( lb );
-        hmin = QListBoxPixmap::height( lb );
+        wmin = QListBoxPixmap::width( lb ) + 8;
+        hmin = QListBoxPixmap::height( lb ) + 8;
     }
     else {
         wmin = QMAX(lb->fontMetrics().width(text()), pixmap()->width()) + 6;
@@ -696,7 +696,8 @@ void KURLBar::slotContextMenuRequested( 
     int result = popup->exec( pos );
     switch ( result ) {
         case IconSize:
-            setIconSize( smallIcons ? KIcon::SizeMedium : KIcon::SizeSmall );
+			// MM: SizeSmall -> SizeSmallMedium
+            setIconSize( smallIcons ? KIcon::SizeMedium : KIcon::SizeSmallMedium );
             m_listBox->triggerUpdate( true );
             break;
         case AddItem:


_______________________________________________
kde-usability mailing list
kde-usability@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-usability


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic