[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    Re: Desktop labels
From:       Ryan Cumming <ryan () completely ! kicks-ass ! org>
Date:       2002-08-23 22:03:53
[Download RAW message or body]

On August 23, 2002 09:11, Aaron J. Seigo wrote:
> > It's implicit that i want to <make something> here where I put my
> > pointer.
> >
> > "Copy"
> > "Move"
> > "Create link"
> >
> > Windows too do this in the same way.
>
> patch? usability report?

Here's a patch. This is just a friendly gesture, not an endorsement, BTW ;)

-Ryan
["operations_menu.diff" (text/x-diff)]

Index: konq_iconviewwidget.cc
===================================================================
RCS file: /home/kde/kdebase/libkonq/konq_iconviewwidget.cc,v
retrieving revision 1.207
diff -u -r1.207 konq_iconviewwidget.cc
--- konq_iconviewwidget.cc	2002/06/27 20:48:38	1.207
+++ konq_iconviewwidget.cc	2002/08/23 22:00:28
@@ -813,15 +813,17 @@
              stopAll ||
              mimeTypeMatch( ivi->item()->mimetype(), stopImagePreviewFor ) )
         {
-            ivi->setIcon( size, ivi->state(), true, true );
+            ivi->setIcon( size, ivi->state(), true, false );
         }
         else
-            ivi->invalidateThumb( ivi->state(), true );
+            ivi->invalidateThumb( ivi->state(), false );
     }
     if ( autoArrange() && (oldGridX != gridX() || !stopImagePreviewFor.isEmpty()) )
     {
-        arrangeItemsInGrid( true ); // take new grid into account
+        arrangeItemsInGrid( true ); // take new grid into account + repaint
     }
+    else
+       update();
 }
 
 bool KonqIconViewWidget::mimeTypeMatch( const QString& mimeType, const QStringList& mimeList ) const
Index: konq_operations.cc
===================================================================
RCS file: /home/kde/kdebase/libkonq/konq_operations.cc,v
retrieving revision 1.99
diff -u -r1.99 konq_operations.cc
--- konq_operations.cc	2002/05/25 11:27:31	1.99
+++ konq_operations.cc	2002/08/23 22:00:28
@@ -562,10 +562,10 @@
         // Nor control nor shift are pressed => show popup menu
         QPopupMenu popup;
         if ( sReading )
-            popup.insertItem(SmallIconSet("editcopy"), i18n( "&Copy Here" ), 1 );
+            popup.insertItem(SmallIconSet("editcopy"), i18n( "&Copy" ), 1 );
         if ( (sMoving || (sReading && sDeleting)) )
-            popup.insertItem( i18n( "&Move Here" ), 2 );
-        popup.insertItem(SmallIconSet("www"), i18n( "&Link Here" ), 3 );
+            popup.insertItem( i18n( "&Move" ), 2 );
+        popup.insertItem(SmallIconSet("www"), i18n( "Create &Link" ), 3 );
         if (bSetWallpaper)
             popup.insertItem(SmallIconSet("background"), i18n( "Set as &Wallpaper" ), 4 );
         popup.insertSeparator();

_______________________________________________
kde-usability mailing list
kde-usability@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-usability

[prev in list] [next in list] [prev in thread] [next in thread]