[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 130188: ktp-common-internals improvements
From: James Smith <smithjd15 () gmail ! com>
Date: 2017-08-01 19:00:08
Message-ID: 20170801190008.5572.22764 () mimi ! kde ! org
[Download RAW message or body]
--===============7806777910354441613==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On July 28, 2017, 2:15 p.m., David Edmundson wrote:
> > KTp/Models/accounts-list-model.cpp, line 211
> > <https://git.reviewboard.kde.org/r/130188/diff/1/?file=498227#file498227line211>
> >
> > why do we have to block?
The call is async so the error value can be non-valid.
> On July 28, 2017, 2:15 p.m., David Edmundson wrote:
> > KTp/global-presence.h, line 118
> > <https://git.reviewboard.kde.org/r/130188/diff/1/?file=498230#file498230line118>
> >
> > There was an introduction of a global static for this.
> >
> > It might be worth, long term, changing everything to that.
That would mean changing consumers, not this export?
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130188/#review103499
-----------------------------------------------------------
On July 28, 2017, 12:08 p.m., James Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130188/
> -----------------------------------------------------------
>
> (Updated July 28, 2017, 12:08 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-common-internals
>
>
> Description
> -------
>
> Integrate Status Handler. API additions and cleanup. Bugfixes and documentation.
>
>
> Diffs
> -----
>
> KTp/Declarative/qml-plugins.cpp 27ed202be547c088feaba92664b64617e3e541fc
> KTp/Models/accounts-list-model.h 09b1c28d1519dcfad24540008eab4ff0fadfd425
> KTp/Models/accounts-list-model.cpp 216102658db0d9183ccfe851807db3117e2df1f9
> KTp/Models/presence-model.h 7d35c9f529e51d1300926bc90a2674234ab87cfe
> KTp/Models/presence-model.cpp 9d32174df8b1052f7f01a7e31c8f5cbf44a445ee
> KTp/global-presence.h 46e6cc358b0f3cdaff35d3a7be25949646b400d3
> KTp/global-presence.cpp 0b751b145a227d59de564baa21bed1df0b23b125
> KTp/types.h 8d3ca4fc14a37b61abecdf78594f334f7b6aa797
>
> Diff: https://git.reviewboard.kde.org/r/130188/diff/
>
>
> Testing
> -------
>
> Compile, run.
>
>
> Thanks,
>
> James Smith
>
>
--===============7806777910354441613==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130188/">https://git.reviewboard.kde.org/r/130188/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 28th, 2017, 2:15 p.m. MDT, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/130188/diff/1/?file=498227#file498227line211" \
style="color: black; font-weight: bold; text-decoration: \
underline;">KTp/Models/accounts-list-model.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">201</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">call</span><span class="p">.</span><span \
class="n">waitForFinished</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why \
do we have to block?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The call is async so the error value can be non-valid.</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 28th, 2017, 2:15 p.m. MDT, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/130188/diff/1/?file=498230#file498230line118" \
style="color: black; font-weight: bold; text-decoration: \
underline;">KTp/global-presence.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">116</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Tp</span><span class="o">::</span><span class="n">AccountManagerPtr</span> \
<span class="n">accountManager</span><span class="p">()</span> <span \
class="k">const</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There \
was an introduction of a global static for this.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
might be worth, long term, changing everything to that.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">That would mean changing consumers, not this export?</p></pre> <br />
<p>- James</p>
<br />
<p>On July 28th, 2017, 12:08 p.m. MDT, James Smith wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By James Smith.</div>
<p style="color: grey;"><i>Updated July 28, 2017, 12:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Integrate Status Handler. API additions and cleanup. \
Bugfixes and documentation.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compile, run.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Declarative/qml-plugins.cpp <span style="color: \
grey">(27ed202be547c088feaba92664b64617e3e541fc)</span></li>
<li>KTp/Models/accounts-list-model.h <span style="color: \
grey">(09b1c28d1519dcfad24540008eab4ff0fadfd425)</span></li>
<li>KTp/Models/accounts-list-model.cpp <span style="color: \
grey">(216102658db0d9183ccfe851807db3117e2df1f9)</span></li>
<li>KTp/Models/presence-model.h <span style="color: \
grey">(7d35c9f529e51d1300926bc90a2674234ab87cfe)</span></li>
<li>KTp/Models/presence-model.cpp <span style="color: \
grey">(9d32174df8b1052f7f01a7e31c8f5cbf44a445ee)</span></li>
<li>KTp/global-presence.h <span style="color: \
grey">(46e6cc358b0f3cdaff35d3a7be25949646b400d3)</span></li>
<li>KTp/global-presence.cpp <span style="color: \
grey">(0b751b145a227d59de564baa21bed1df0b23b125)</span></li>
<li>KTp/types.h <span style="color: \
grey">(8d3ca4fc14a37b61abecdf78594f334f7b6aa797)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130188/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7806777910354441613==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic