From kde-telepathy  Sat Jul 29 20:24:47 2017
From: Martin Klapetek <martin.klapetek () gmail ! com>
Date: Sat, 29 Jul 2017 20:24:47 +0000
To: kde-telepathy
Subject: Re: Review Request 130192: ktp-kded-module improvements
Message-Id: <20170729202447.7706.72714 () mimi ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-telepathy&m=150135990313280

--===============3077207956878047646==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit



> On July 28, 2017, 10:25 p.m., David Edmundson wrote:
> > account-status-helper.cpp, line 60
> > <https://git.reviewboard.kde.org/r/130192/diff/1/?file=498255#file498255line60>
> >
> >     stick in the top before { please
> >     
> >     
> >     Also, can you make this not leak

Have you actually tested any of these before giving it a Ship it?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130192/#review103502
-----------------------------------------------------------


On July 28, 2017, 8:08 p.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130192/
> -----------------------------------------------------------
> 
> (Updated July 28, 2017, 8:08 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 284517, 293443, 294940, 297924, and 334542
>     http://bugs.kde.org/show_bug.cgi?id=284517
>     http://bugs.kde.org/show_bug.cgi?id=293443
>     http://bugs.kde.org/show_bug.cgi?id=294940
>     http://bugs.kde.org/show_bug.cgi?id=297924
>     http://bugs.kde.org/show_bug.cgi?id=334542
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Make unit testing compile. Implement independent account presences and integrate KActivities. Implement status message parser and integrate with Now Playing. Add parser unit tests.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c766a5419f60af21cf49903b28a92450be702b78 
>   account-status-helper.h PRE-CREATION 
>   account-status-helper.cpp PRE-CREATION 
>   autoaway.h 5e2a56100b56e6d21bc649f9032c8bece9031452 
>   autoaway.cpp 4881c71afab2be2468c3c883523d2844865e6247 
>   autoconnect.h 0f3ab137cf67cce9c7467144a45d1706ec9cc007 
>   autoconnect.cpp 99512b265e0e6ae34f83263ffa6337741db652ea 
>   config/CMakeLists.txt c89b7aa5c7f0d140e8b67446710afa085a411cc6 
>   config/nowplaying-lineedit.h 23f2fee8f164ab762a17e57c70a4e38a33616e5b 
>   config/nowplaying-lineedit.cpp 5bc1f61d0cd0ca43a89e12eab4bcf7e4de540111 
>   config/nowplaying-listwidget.h f80eb1ecdbacf29887ffa7d522263452a597872e 
>   config/nowplaying-listwidget.cpp 638f4c5b6c1fb4604f99d729d2c220d2ade94677 
>   config/telepathy-kded-config.h 0400626f205468b1ac9c6964d96a9644ceec32c3 
>   config/telepathy-kded-config.cpp 88220645c2e119dc7879cdae065cbbf06aa13329 
>   config/telepathy-kded-config.ui 2b80dfa34381af2e9206384a31c025f9b914854a 
>   org.kde.Telepathy.AccountStatusHelper.xml PRE-CREATION 
>   screensaveraway.h 92344e891ccde16d53771c3e279d845f4d800b2d 
>   screensaveraway.cpp f226564a5bf7b396965b5ae21f81d93b7edc3ef8 
>   status-handler.h 06240ff17e22148f2b128bc0eb8cec6d6abe68ff 
>   status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc 
>   status-message-parser.h PRE-CREATION 
>   status-message-parser.cpp PRE-CREATION 
>   telepathy-kded-module-plugin.h 4c161696a706e82059a7eb314773c3644fe26bd7 
>   telepathy-kded-module-plugin.cpp daf73c66947bc946097de7a8e8a1518555131145 
>   telepathy-module.h 17ef4cef27b90cbced6c66846ed82cb5c36fb532 
>   telepathy-module.cpp b74053bc1817d773a4fe37769e42f4013ced5425 
>   telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 
>   telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 
>   tests/CMakeLists.txt 7ec77495417a6790060ea5ea7126c46399dff755 
>   tests/status-handling-main.cpp 9fddb13a7c172df2cf3fa8cdf7e5e7836582d1db 
>   tests/status-message-parser.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/130192/diff/
> 
> 
> Testing
> -------
> 
> Compile, run. Unit testing.
> 
> 
> Thanks,
> 
> James Smith
> 
>


--===============3077207956878047646==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/130192/">https://git.reviewboard.kde.org/r/130192/</a>
     </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On July 28th, 2017, 10:25 p.m. CEST, <b>David Edmundson</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  


<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/130192/diff/1/?file=498255#file498255line60" style="color: black; font-weight: bold; text-decoration: underline;">account-status-helper.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">60</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">m_activities</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KActivities</span><span class="o">::</span><span class="n">Consumer</span><span class="p">();</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">stick in the top before { please</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, can you make this not leak</p></pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Have you actually tested any of these before giving it a Ship it?</p></pre>
<br />




<p>- Martin</p>


<br />
<p>On July 28th, 2017, 8:08 p.m. CEST, James Smith wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By James Smith.</div>


<p style="color: grey;"><i>Updated July 28, 2017, 8:08 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=284517">284517</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=293443">293443</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=294940">294940</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=297924">297924</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=334542">334542</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-kded-module
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Make unit testing compile. Implement independent account presences and integrate KActivities. Implement status message parser and integrate with Now Playing. Add parser unit tests.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compile, run. Unit testing.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(c766a5419f60af21cf49903b28a92450be702b78)</span></li>

 <li>account-status-helper.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>account-status-helper.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autoaway.h <span style="color: grey">(5e2a56100b56e6d21bc649f9032c8bece9031452)</span></li>

 <li>autoaway.cpp <span style="color: grey">(4881c71afab2be2468c3c883523d2844865e6247)</span></li>

 <li>autoconnect.h <span style="color: grey">(0f3ab137cf67cce9c7467144a45d1706ec9cc007)</span></li>

 <li>autoconnect.cpp <span style="color: grey">(99512b265e0e6ae34f83263ffa6337741db652ea)</span></li>

 <li>config/CMakeLists.txt <span style="color: grey">(c89b7aa5c7f0d140e8b67446710afa085a411cc6)</span></li>

 <li>config/nowplaying-lineedit.h <span style="color: grey">(23f2fee8f164ab762a17e57c70a4e38a33616e5b)</span></li>

 <li>config/nowplaying-lineedit.cpp <span style="color: grey">(5bc1f61d0cd0ca43a89e12eab4bcf7e4de540111)</span></li>

 <li>config/nowplaying-listwidget.h <span style="color: grey">(f80eb1ecdbacf29887ffa7d522263452a597872e)</span></li>

 <li>config/nowplaying-listwidget.cpp <span style="color: grey">(638f4c5b6c1fb4604f99d729d2c220d2ade94677)</span></li>

 <li>config/telepathy-kded-config.h <span style="color: grey">(0400626f205468b1ac9c6964d96a9644ceec32c3)</span></li>

 <li>config/telepathy-kded-config.cpp <span style="color: grey">(88220645c2e119dc7879cdae065cbbf06aa13329)</span></li>

 <li>config/telepathy-kded-config.ui <span style="color: grey">(2b80dfa34381af2e9206384a31c025f9b914854a)</span></li>

 <li>org.kde.Telepathy.AccountStatusHelper.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>screensaveraway.h <span style="color: grey">(92344e891ccde16d53771c3e279d845f4d800b2d)</span></li>

 <li>screensaveraway.cpp <span style="color: grey">(f226564a5bf7b396965b5ae21f81d93b7edc3ef8)</span></li>

 <li>status-handler.h <span style="color: grey">(06240ff17e22148f2b128bc0eb8cec6d6abe68ff)</span></li>

 <li>status-handler.cpp <span style="color: grey">(4b9c25a2ccba451f6e608bb704626e33149108cc)</span></li>

 <li>status-message-parser.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>status-message-parser.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>telepathy-kded-module-plugin.h <span style="color: grey">(4c161696a706e82059a7eb314773c3644fe26bd7)</span></li>

 <li>telepathy-kded-module-plugin.cpp <span style="color: grey">(daf73c66947bc946097de7a8e8a1518555131145)</span></li>

 <li>telepathy-module.h <span style="color: grey">(17ef4cef27b90cbced6c66846ed82cb5c36fb532)</span></li>

 <li>telepathy-module.cpp <span style="color: grey">(b74053bc1817d773a4fe37769e42f4013ced5425)</span></li>

 <li>telepathy-mpris.h <span style="color: grey">(05b77c90a50372fd9ed66bde0ab8a287caf34b51)</span></li>

 <li>telepathy-mpris.cpp <span style="color: grey">(ee0e622c68bdd156e45914f542d2fe13f0ddb610)</span></li>

 <li>tests/CMakeLists.txt <span style="color: grey">(7ec77495417a6790060ea5ea7126c46399dff755)</span></li>

 <li>tests/status-handling-main.cpp <span style="color: grey">(9fddb13a7c172df2cf3fa8cdf7e5e7836582d1db)</span></li>

 <li>tests/status-message-parser.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/130192/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============3077207956878047646==--