[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 127005: Port to QWebEngine
From: Niels Ole Salscheider <niels_ole () salscheider-online ! de>
Date: 2017-02-11 18:35:05
Message-ID: 20170211183505.21138.43432 () mimi ! kde ! org
[Download RAW message or body]
--===============0388577251387229331==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Feb. 8, 2016, 3:14 nachm., Martin Klapetek wrote:
> > Thanks for working on this
> >
> > Do you know what's the status of webengine packaging in distros? Last time I \
> > remember they were much unhappy about it. If they cannot package that, we won't \
> > be able to use this.
> > That said, do the filter plugins work too?
>
> Niels Ole Salscheider wrote:
> I think the situation got much better with Qt 5.6 since many libraries were \
> unbundled. We did not have many problems packaging it for Exherbo but it seems to \
> be a bit more complicated for the BSDs. I thought that there were other \
> applications in KDE using it (at least in some feature branches), but I might be \
> wrong. We should definitely find out about that.
> You mean things like emoticons, the image preview, and so on? These seem to work.
KDE PIM has now a hard dependency on QtWebEngine. Do you think that we could get this \
change in nowadays?
- Niels Ole
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127005/#review92169
-----------------------------------------------------------
On Feb. 11, 2017, 6:32 nachm., Niels Ole Salscheider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127005/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2017, 6:32 nachm.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-text-ui
>
>
> Description
> -------
>
> This ports the message viewer from QWebKit to QWebEngine.
>
>
> Diffs
> -----
>
> CMakeLists.txt 86aa80a
> adiumxtra-protocol-handler/CMakeLists.txt f78a62f
> app/CMakeLists.txt 9a90cec
> config/appearance/CMakeLists.txt dfb5d04
> config/appearance/appearance-config-tab.cpp f2f298b
> lib/CMakeLists.txt 5294521
> lib/adium-theme-view.h 5a0c2e6
> lib/adium-theme-view.cpp d1c93f4
> lib/chat-search-bar.h c8c5118
> lib/chat-search-bar.cpp 484975a
> lib/chat-widget.h 588407c
> lib/chat-widget.cpp fdc9c1e
> logviewer/CMakeLists.txt c36157c
> logviewer/log-viewer.cpp b1dad26
> logviewer/message-view.h ec592c7
> logviewer/message-view.cpp 1b3bbe4
>
> Diff: https://git.reviewboard.kde.org/r/127005/diff/
>
>
> Testing
> -------
>
> - Builds
> - Chats with the text UI work
> - Links work
> - The log viewer works
>
>
> Thanks,
>
> Niels Ole Salscheider
>
>
--===============0388577251387229331==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127005/">https://git.reviewboard.kde.org/r/127005/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Februar 8th, 2016, 3:14 nachm. UTC, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Thanks for working on this</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do \
you know what's the status of webengine packaging in distros? Last time I remember \
they were much unhappy about it. If they cannot package that, we won't be able to use \
this.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">That said, do the filter plugins work too?</p></pre> \
</blockquote>
<p>On Februar 8th, 2016, 7 nachm. UTC, <b>Niels Ole Salscheider</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think the situation got much better with Qt 5.6 since many libraries were unbundled. \
We did not have many problems packaging it for Exherbo but it seems to be a bit more \
complicated for the BSDs. I thought that there were other applications in KDE using \
it (at least in some feature branches), but I might be wrong. We should definitely \
find out about that.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">You mean things like emoticons, the \
image preview, and so on? These seem to work.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KDE \
PIM has now a hard dependency on QtWebEngine. Do you think that we could get this \
change in nowadays?</p></pre> <br />
<p>- Niels Ole</p>
<br />
<p>On Februar 11th, 2017, 6:32 nachm. UTC, Niels Ole Salscheider wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Niels Ole Salscheider.</div>
<p style="color: grey;"><i>Updated Feb. 11, 2017, 6:32 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This ports the message viewer from QWebKit to \
QWebEngine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Builds</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Chats with the text UI work</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Links work</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">The log viewer works</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(86aa80a)</span></li>
<li>adiumxtra-protocol-handler/CMakeLists.txt <span style="color: \
grey">(f78a62f)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(9a90cec)</span></li>
<li>config/appearance/CMakeLists.txt <span style="color: grey">(dfb5d04)</span></li>
<li>config/appearance/appearance-config-tab.cpp <span style="color: \
grey">(f2f298b)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(5294521)</span></li>
<li>lib/adium-theme-view.h <span style="color: grey">(5a0c2e6)</span></li>
<li>lib/adium-theme-view.cpp <span style="color: grey">(d1c93f4)</span></li>
<li>lib/chat-search-bar.h <span style="color: grey">(c8c5118)</span></li>
<li>lib/chat-search-bar.cpp <span style="color: grey">(484975a)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(588407c)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(fdc9c1e)</span></li>
<li>logviewer/CMakeLists.txt <span style="color: grey">(c36157c)</span></li>
<li>logviewer/log-viewer.cpp <span style="color: grey">(b1dad26)</span></li>
<li>logviewer/message-view.h <span style="color: grey">(ec592c7)</span></li>
<li>logviewer/message-view.cpp <span style="color: grey">(1b3bbe4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127005/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0388577251387229331==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic