[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 126834: ktp-common-internals propagating presence model
From: James Smith <smithjd15 () gmail ! com>
Date: 2016-12-16 1:25:41
Message-ID: 20161216012541.4515.89416 () mimi ! kde ! org
[Download RAW message or body]
--===============8707476474573494816==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126834/
-----------------------------------------------------------
(Updated Dec. 15, 2016, 6:25 p.m.)
Review request for Telepathy and David Edmundson.
Changes
-------
Refactor.
1) Remove m_modelFinishedLoading.
2) presenceModelChanged() -> propagationChange().
3) New modifyModel(KTp::Presence), merges addPresence() and removePresence().
4) propagateModelChange() -> propagateChange(), no longer takes an overload boolean. \
m_presences is now checked if it contains the propagating presence instead. 5) Undo \
change loadDefaultPresences() and loadCustomPresences() into public Q_SLOTS. 6) \
Spread DBus slot connection over multiple lines. 6) Debug changes.
Repository: ktp-common-internals
Description
-------
New features:
-Simplified API, sends and collects changes over DBus.
Diffs (updated)
-----
KTp/Models/presence-model.h 8f206b880f48640626322269a14956f105482f69
KTp/Models/presence-model.cpp ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519
Diff: https://git.reviewboard.kde.org/r/126834/diff/
Testing
-------
Compile, run.
Thanks,
James Smith
--===============8707476474573494816==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126834/">https://git.reviewboard.kde.org/r/126834/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By James Smith.</div>
<p style="color: grey;"><i>Updated Dec. 15, 2016, 6:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Refactor.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">1) Remove \
m_modelFinishedLoading. 2) presenceModelChanged() -> propagationChange().
3) New modifyModel(KTp::Presence), merges addPresence() and removePresence().
4) propagateModelChange() -> propagateChange(), no longer takes an overload \
boolean. m_presences is now checked if it contains the propagating presence instead. \
5) Undo change loadDefaultPresences() and loadCustomPresences() into public Q_SLOTS. \
6) Spread DBus slot connection over multiple lines. 6) Debug changes.</p></pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">New features:
-Simplified API, sends and collects changes over DBus.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compile, run.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Models/presence-model.h <span style="color: \
grey">(8f206b880f48640626322269a14956f105482f69)</span></li>
<li>KTp/Models/presence-model.cpp <span style="color: \
grey">(ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126834/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8707476474573494816==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic