[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 128303: added support for skypeweb
From: Jeremy Whiting <jpwhiting () kde ! org>
Date: 2016-06-28 15:55:09
Message-ID: 20160628155509.5107.91907 () mimi ! kde ! org
[Download RAW message or body]
--===============3792653845675358938==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On June 28, 2016, 9:48 a.m., Björn Bidar wrote:
> > Ship It!
You need to merge this and push it to git. Clicking "Ship it" doesn't do that for \
you.
- Jeremy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128303/#review96926
-----------------------------------------------------------
On June 28, 2016, 8:33 a.m., Björn Bidar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128303/
> -----------------------------------------------------------
>
> (Updated June 28, 2016, 8:33 a.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-accounts-kcm
>
>
> Description
> -------
>
> added support for skypeweb
>
>
> Diffs
> -----
>
> data/kaccounts/ktp-haze-skypeweb-im.service.in PRE-CREATION
> data/kaccounts/ktp-haze-skypeweb.provider.in PRE-CREATION
> plugins/haze/CMakeLists.txt b0a42eb0fc89d18d1009bcb1626ab719ab51286f
> plugins/haze/haze-account-ui-plugin.cpp 102e139e6dbf13aeae3c7315f7e1c582241b7715
> plugins/haze/haze-skypeweb-account.h PRE-CREATION
> plugins/haze/haze-skypeweb-account.cpp PRE-CREATION
> plugins/haze/skypeweb-options-widget.h PRE-CREATION
> plugins/haze/skypeweb-options-widget.cpp PRE-CREATION
> plugins/haze/skypeweb-options-widget.ui PRE-CREATION
> src/KCMTelepathyAccounts/dictionary.cpp 2dab8a108e453b94b5e9f95d00a826f214a023c3
>
> Diff: https://git.reviewboard.kde.org/r/128303/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Björn Bidar
>
>
--===============3792653845675358938==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128303/">https://git.reviewboard.kde.org/r/128303/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 28th, 2016, 9:48 a.m. MDT, <b>Björn \
Bidar</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
need to merge this and push it to git. Clicking "Ship it" doesn't do that for \
you.</p></pre> <br />
<p>- Jeremy</p>
<br />
<p>On June 28th, 2016, 8:33 a.m. MDT, Björn Bidar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Björn Bidar.</div>
<p style="color: grey;"><i>Updated June 28, 2016, 8:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-accounts-kcm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">added support for skypeweb</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/kaccounts/ktp-haze-skypeweb-im.service.in <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>data/kaccounts/ktp-haze-skypeweb.provider.in <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/haze/CMakeLists.txt <span style="color: \
grey">(b0a42eb0fc89d18d1009bcb1626ab719ab51286f)</span></li>
<li>plugins/haze/haze-account-ui-plugin.cpp <span style="color: \
grey">(102e139e6dbf13aeae3c7315f7e1c582241b7715)</span></li>
<li>plugins/haze/haze-skypeweb-account.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/haze/haze-skypeweb-account.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/haze/skypeweb-options-widget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/haze/skypeweb-options-widget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/haze/skypeweb-options-widget.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/dictionary.cpp <span style="color: \
grey">(2dab8a108e453b94b5e9f95d00a826f214a023c3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128303/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3792653845675358938==--
[Attachment #3 (text/plain)]
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic