[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 123485: ktp-kded-module status handler multiple account presence
From: James Smith <smithjd15 () gmail ! com>
Date: 2016-04-04 18:52:37
Message-ID: 20160404185237.15005.35438 () mimi ! kde ! org
[Download RAW message or body]
--===============7912873225078799328==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123485/
-----------------------------------------------------------
(Updated April 4, 2016, 6:52 p.m.)
Review request for Telepathy.
Changes
-------
1) Fix an AccountStatusHelper enable / disable account bug.
Bugs: 293443, 334542, 337881, 340201, and 340781
http://bugs.kde.org/show_bug.cgi?id=293443
http://bugs.kde.org/show_bug.cgi?id=334542
http://bugs.kde.org/show_bug.cgi?id=337881
http://bugs.kde.org/show_bug.cgi?id=340201
http://bugs.kde.org/show_bug.cgi?id=340781
Repository: ktp-kded-module
Description
-------
New classes:
-AccountStatusHelper, a multiple-account-presence QDBusAbstractInterface replacement \
for AutoConnect.
-PluginQueue, a QDBusAbstractInterface for presence and status message plugins.
-Presence / Status Message Inserter classes, for queuing presences and status \
messages.
New properties:
-TelepathyKDEDModulePlugin: KTp::PluginQueue pluginState().
New methods:
-TelepathyKDEDModulePlugin: virtual pluginInit(bool), method \
setPluginState(KTp::PluginQueue), method configureEnabled(bool).
New features:
-Newly enabled and online account presence changes to offline or account requested \
presence depending on network connection state and autoconnect \
property.
-Offline global presence will override per-account presences temporarily.
-PluginQueue globs presence change events.
-StatusHandler dynamically disables and enables plugin queues if there are online \
accounts.
-StatusHandler and TelepathyKDEDModulePlugin no longer require GlobalPresence.
Various other cleanups, documentation, and improvements.
Diffs (updated)
-----
CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5
account-status-helper.h PRE-CREATION
account-status-helper.cpp PRE-CREATION
autoaway.h 5e2a56100b56e6d21bc649f9032c8bece9031452
autoaway.cpp 4881c71afab2be2468c3c883523d2844865e6247
autoconnect.h 0f3ab137cf67cce9c7467144a45d1706ec9cc007
autoconnect.cpp 99512b265e0e6ae34f83263ffa6337741db652ea
config/telepathy-kded-config.cpp 4ed6a16cc8f489794a08a3c031d7a8ec7b010b2d
config/telepathy-kded-config.ui 2b80dfa34381af2e9206384a31c025f9b914854a
org.kde.Telepathy.AccountStatusHelper.xml PRE-CREATION
org.kde.Telepathy.PluginQueue.xml PRE-CREATION
screensaveraway.h 92344e891ccde16d53771c3e279d845f4d800b2d
screensaveraway.cpp f226564a5bf7b396965b5ae21f81d93b7edc3ef8
status-handler-plugin-queue.h PRE-CREATION
status-handler-plugin-queue.cpp PRE-CREATION
status-handler.h 06240ff17e22148f2b128bc0eb8cec6d6abe68ff
status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc
telepathy-kded-module-plugin.h 4c161696a706e82059a7eb314773c3644fe26bd7
telepathy-kded-module-plugin.cpp daf73c66947bc946097de7a8e8a1518555131145
telepathy-module.h 17ef4cef27b90cbced6c66846ed82cb5c36fb532
telepathy-module.cpp b74053bc1817d773a4fe37769e42f4013ced5425
telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51
telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610
telepathy-status-inserter.h PRE-CREATION
telepathy-status-inserter.cpp PRE-CREATION
tests/CMakeLists.txt 7ec77495417a6790060ea5ea7126c46399dff755
Diff: https://git.reviewboard.kde.org/r/123485/diff/
Testing
-------
Compile, run.
Thanks,
James Smith
--===============7912873225078799328==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123485/">https://git.reviewboard.kde.org/r/123485/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By James Smith.</div>
<p style="color: grey;"><i>Updated April 4, 2016, 6:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1) Fix an AccountStatusHelper enable / disable account bug.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=293443">293443</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=334542">334542</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=337881">337881</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=340201">340201</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=340781">340781</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-kded-module
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">New classes:
-AccountStatusHelper, a multiple-account-presence QDBusAbstractInterface replacement \
for AutoConnect.
-PluginQueue, a QDBusAbstractInterface for presence and status message plugins.
-Presence / Status Message Inserter classes, for queuing presences and status \
messages.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">New properties:
-TelepathyKDEDModulePlugin: KTp::PluginQueue pluginState().</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">New methods:
-TelepathyKDEDModulePlugin: virtual pluginInit(bool), method \
setPluginState(KTp::PluginQueue), method configureEnabled(bool).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">New features:
-Newly enabled and online account presence changes to offline or account requested \
presence depending on network connection state and autoconnect \
property.
-Offline global presence will override per-account presences temporarily.
-PluginQueue globs presence change events.
-StatusHandler dynamically disables and enables plugin queues if there are online \
accounts.
-StatusHandler and TelepathyKDEDModulePlugin no longer require GlobalPresence.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Various other cleanups, documentation, and \
improvements.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compile, run.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(ceb0b7768e894ed70528187d178b0979a90754f5)</span></li>
<li>account-status-helper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>account-status-helper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autoaway.h <span style="color: \
grey">(5e2a56100b56e6d21bc649f9032c8bece9031452)</span></li>
<li>autoaway.cpp <span style="color: \
grey">(4881c71afab2be2468c3c883523d2844865e6247)</span></li>
<li>autoconnect.h <span style="color: \
grey">(0f3ab137cf67cce9c7467144a45d1706ec9cc007)</span></li>
<li>autoconnect.cpp <span style="color: \
grey">(99512b265e0e6ae34f83263ffa6337741db652ea)</span></li>
<li>config/telepathy-kded-config.cpp <span style="color: \
grey">(4ed6a16cc8f489794a08a3c031d7a8ec7b010b2d)</span></li>
<li>config/telepathy-kded-config.ui <span style="color: \
grey">(2b80dfa34381af2e9206384a31c025f9b914854a)</span></li>
<li>org.kde.Telepathy.AccountStatusHelper.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>org.kde.Telepathy.PluginQueue.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>screensaveraway.h <span style="color: \
grey">(92344e891ccde16d53771c3e279d845f4d800b2d)</span></li>
<li>screensaveraway.cpp <span style="color: \
grey">(f226564a5bf7b396965b5ae21f81d93b7edc3ef8)</span></li>
<li>status-handler-plugin-queue.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>status-handler-plugin-queue.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>status-handler.h <span style="color: \
grey">(06240ff17e22148f2b128bc0eb8cec6d6abe68ff)</span></li>
<li>status-handler.cpp <span style="color: \
grey">(4b9c25a2ccba451f6e608bb704626e33149108cc)</span></li>
<li>telepathy-kded-module-plugin.h <span style="color: \
grey">(4c161696a706e82059a7eb314773c3644fe26bd7)</span></li>
<li>telepathy-kded-module-plugin.cpp <span style="color: \
grey">(daf73c66947bc946097de7a8e8a1518555131145)</span></li>
<li>telepathy-module.h <span style="color: \
grey">(17ef4cef27b90cbced6c66846ed82cb5c36fb532)</span></li>
<li>telepathy-module.cpp <span style="color: \
grey">(b74053bc1817d773a4fe37769e42f4013ced5425)</span></li>
<li>telepathy-mpris.h <span style="color: \
grey">(05b77c90a50372fd9ed66bde0ab8a287caf34b51)</span></li>
<li>telepathy-mpris.cpp <span style="color: \
grey">(ee0e622c68bdd156e45914f542d2fe13f0ddb610)</span></li>
<li>telepathy-status-inserter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>telepathy-status-inserter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/CMakeLists.txt <span style="color: \
grey">(7ec77495417a6790060ea5ea7126c46399dff755)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123485/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7912873225078799328==--
[Attachment #3 (text/plain)]
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic