[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 127005: Port to QWebEngine
From: Niels Ole Salscheider <niels_ole () salscheider-online ! de>
Date: 2016-02-08 19:00:32
Message-ID: 20160208190032.23891.11975 () mimi ! kde ! org
[Download RAW message or body]
--===============4106553184018311201==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Feb. 8, 2016, 3:14 p.m., Martin Klapetek wrote:
> > Thanks for working on this
> >
> > Do you know what's the status of webengine packaging in distros? Last time I \
> > remember they were much unhappy about it. If they cannot package that, we won't \
> > be able to use this.
> > That said, do the filter plugins work too?
I think the situation got much better with Qt 5.6 since many libraries were \
unbundled. We did not have many problems packaging it for Exherbo but it seems to be \
a bit more complicated for the BSDs. I thought that there were other applications in \
KDE using it (at least in some feature branches), but I might be wrong. We should \
definitely find out about that.
You mean things like emoticons, the image preview, and so on? These seem to work.
> On Feb. 8, 2016, 3:14 p.m., Martin Klapetek wrote:
> > lib/adium-theme-view.h, line 173
> > <https://git.reviewboard.kde.org/r/127005/diff/1/?file=443601#file443601line173>
> >
> > This worked based on a config file option. I imagine we can replace this with \
> > qputenv("QTWEBENGINE_REMOTE_DEBUGGING"...) instead? Ie. keep the config option \
> > working.
Yes, QTWEBENGINE_REMOTE_DEBUGGING is the new way for the inspector in QWebEngine.
Using qputenv would be possible, but you have to set QTWEBENGINE_REMOTE_DEBUGGING to \
a port number and then point you web browser to that port. I think it would be easier \
to just set that env var manually when you want the inspector.
> On Feb. 8, 2016, 3:14 p.m., Martin Klapetek wrote:
> > lib/adium-theme-view.cpp, line 112
> > <https://git.reviewboard.kde.org/r/127005/diff/1/?file=443602#file443602line112>
> >
> > This seems to be lost?
Unfortunately, this seems not to be available in QWebEngine at the moment...
> On Feb. 8, 2016, 3:14 p.m., Martin Klapetek wrote:
> > lib/adium-theme-view.cpp, line 315
> > <https://git.reviewboard.kde.org/r/127005/diff/1/?file=443602#file443602line315>
> >
> > Why this whole thing is being removed?
JavaScript proxies are not available in QWebEngine. Instead, you are supposed to use \
QWebChannel to communicate with the C++ side.
But the only purpose of this is to emit the viewReady signal when the page is loaded. \
We can instead just emit it when the QWebEngineView emits loadFinished.
AFAICT this is only used for the style preview and that works also with the new code.
- Niels Ole
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127005/#review92169
-----------------------------------------------------------
On Feb. 7, 2016, 8:21 p.m., Niels Ole Salscheider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127005/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2016, 8:21 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-text-ui
>
>
> Description
> -------
>
> This ports the message viewer from QWebKit to QWebEngine.
>
>
> Diffs
> -----
>
> CMakeLists.txt 91cd304
> adiumxtra-protocol-handler/CMakeLists.txt f78a62f
> app/CMakeLists.txt 9a90cec
> config/appearance/CMakeLists.txt dfb5d04
> config/appearance/appearance-config-tab.cpp f2f298b
> lib/CMakeLists.txt 5294521
> lib/adium-theme-view.h 5a0c2e6
> lib/adium-theme-view.cpp 26e6d50
> lib/chat-search-bar.h c8c5118
> lib/chat-search-bar.cpp 484975a
> lib/chat-widget.h 588407c
> lib/chat-widget.cpp 7975057
> logviewer/CMakeLists.txt c36157c
> logviewer/log-viewer.cpp 1ae0f7b
> logviewer/message-view.h ec592c7
> logviewer/message-view.cpp eafc53e
>
> Diff: https://git.reviewboard.kde.org/r/127005/diff/
>
>
> Testing
> -------
>
> - Builds
> - Chats with the text UI work
> - Links work
> - The log viewer works
>
>
> Thanks,
>
> Niels Ole Salscheider
>
>
--===============4106553184018311201==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127005/">https://git.reviewboard.kde.org/r/127005/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 8th, 2016, 3:14 p.m. UTC, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Thanks for working on this</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do \
you know what's the status of webengine packaging in distros? Last time I remember \
they were much unhappy about it. If they cannot package that, we won't be able to use \
this.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">That said, do the filter plugins work too?</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think the situation got much better with Qt 5.6 since many libraries were unbundled. \
We did not have many problems packaging it for Exherbo but it seems to be a bit more \
complicated for the BSDs. I thought that there were other applications in KDE using \
it (at least in some feature branches), but I might be wrong. We should definitely \
find out about that.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">You mean things like emoticons, the \
image preview, and so on? These seem to work.</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 8th, 2016, 3:14 p.m. UTC, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127005/diff/1/?file=443601#file443601line173" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/adium-theme-view.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">160</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">bool</span> <span class="n">m_webInspector</span><span \
class="p">;</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
worked based on a config file option. I imagine we can replace this with \
qputenv("QTWEBENGINE_REMOTE_DEBUGGING"...) instead? Ie. keep the config option \
working.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Yes, QTWEBENGINE_REMOTE_DEBUGGING is the new way for the inspector in \
QWebEngine. Using qputenv would be possible, but you have to set \
QTWEBENGINE_REMOTE_DEBUGGING to a port number and then point you web browser to that \
port. I think it would be easier to just set that env var manually when you want the \
inspector.</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 8th, 2016, 3:14 p.m. UTC, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127005/diff/1/?file=443602#file443602line112" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/adium-theme-view.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">79</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">ws</span><span class="o">-></span><span \
class="n">setAttribute</span><span class="p">(</span><span \
class="n">QWebSettings</span><span class="o">::</span><span \
class="n">ZoomTextOnly</span><span class="p">,</span> <span \
class="nb">true</span><span class="p">);</span></pre></td> <th bgcolor="#ebb1ba" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
seems to be lost?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Unfortunately, this seems not to be available in QWebEngine at the \
moment...</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 8th, 2016, 3:14 p.m. UTC, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127005/diff/1/?file=443602#file443602line315" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/adium-theme-view.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">282</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// The \
purpose of this regular expression is to find the body tag in the \
template</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why \
this whole thing is being removed?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">JavaScript proxies are not available in QWebEngine. Instead, you are \
supposed to use QWebChannel to communicate with the C++ side.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But \
the only purpose of this is to emit the viewReady signal when the page is loaded. We \
can instead just emit it when the QWebEngineView emits loadFinished.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">AFAICT this is only used for the style preview and that works also with the \
new code.</p></pre> <br />
<p>- Niels Ole</p>
<br />
<p>On February 7th, 2016, 8:21 p.m. UTC, Niels Ole Salscheider wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Niels Ole Salscheider.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2016, 8:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This ports the message viewer from QWebKit to \
QWebEngine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Builds</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Chats with the text UI work</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Links work</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">The log viewer works</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(91cd304)</span></li>
<li>adiumxtra-protocol-handler/CMakeLists.txt <span style="color: \
grey">(f78a62f)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(9a90cec)</span></li>
<li>config/appearance/CMakeLists.txt <span style="color: grey">(dfb5d04)</span></li>
<li>config/appearance/appearance-config-tab.cpp <span style="color: \
grey">(f2f298b)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(5294521)</span></li>
<li>lib/adium-theme-view.h <span style="color: grey">(5a0c2e6)</span></li>
<li>lib/adium-theme-view.cpp <span style="color: grey">(26e6d50)</span></li>
<li>lib/chat-search-bar.h <span style="color: grey">(c8c5118)</span></li>
<li>lib/chat-search-bar.cpp <span style="color: grey">(484975a)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(588407c)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(7975057)</span></li>
<li>logviewer/CMakeLists.txt <span style="color: grey">(c36157c)</span></li>
<li>logviewer/log-viewer.cpp <span style="color: grey">(1ae0f7b)</span></li>
<li>logviewer/message-view.h <span style="color: grey">(ec592c7)</span></li>
<li>logviewer/message-view.cpp <span style="color: grey">(eafc53e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127005/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4106553184018311201==--
[Attachment #3 (text/plain)]
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic