[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Porting TelepathyLoggerQt to Qt5
From: Aleix Pol <aleixpol () kde ! org>
Date: 2014-10-28 15:09:15
Message-ID: CACcA1Royb2V-=ztZrEcNxLooG0jxmnUfQ2PK1nJD7z3hrHJHDg () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Tue, Oct 28, 2014 at 3:49 PM, Daniel Vratil <dvratil@redhat.com> wrote:
> On Tuesday 28 of October 2014 15:25:59 Aleix Pol wrote:
> > On Mon, Oct 27, 2014 at 10:23 AM, Daniel Vratil <dvratil@redhat.com>
> wrote:
> > > On Friday 24 of October 2014 15:51:59 Aleix Pol wrote:
> > > > Hi,
> > > > I just pushed a new branch to get the project to compile with Qt5.
> [1]
> > >
> > > The
> > >
> > > > branch is called qt5.
> > >
> > > Thanks, you rock!
> > >
> > > > Please Dan can you take a look and see how badly I messed up? :D
> > >
> > > Looks ok to me :-)
> > >
> > > Dan
> > >
> > > > Cheers!
> > > > Aleix
> > > >
> > > > [1]
> > >
> > >
> http://commits.kde.org/telepathy-logger-qt/594d2c32c1bd088e98f32a4b88500b5
> > > f4>
> > > > ffdc7e1
> >
> > Ok, so what do we do about that? Qt5 in master?
> > Who needs to be told?
>
> I am not familiar with KTp release plans (sadly I haven't been around this
> project much lately) - but if next release is going to be Qt5-based, the
> merging can happen at any point, after we solve the following:
>
> Version number: I made TelepathyLoggerQt versioning follow upstream
> (TelepathyLogger), but now we would have to diverge as 0.8 is Qt4 build...
>
Sure :)
>
> Merge noqtglib: I've ported away from QtGLib on the KTp sprint in May, but
> the
> branch did not get merged, because I....kinda forgot about it. Since it's
> an
> ABI break, this is a good point to merge it. But could also happen after
> merging Qt 5 to master, so not really important at this point.
>
I would say it's fine if you merge it right now in the qt5 branch.
>
> CI requirements: we now require TelepathyQt5, so we have to check with
> sysadmins first whether it is available on the CI. Apparently we have
> telepathy-qt4 builds on the CI, so we probably should ask them to add
> telepathy-qt5 builds and build against them (?).
>
Sure, we actually need to take into account the CI for KTp altogether
anyway...
Aleix
[Attachment #5 (text/html)]
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Oct 28, 2014 \
at 3:49 PM, Daniel Vratil <span dir="ltr"><<a href="mailto:dvratil@redhat.com" \
target="_blank">dvratil@redhat.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><span class="">On Tuesday 28 of October 2014 15:25:59 Aleix \
Pol wrote:<br> > On Mon, Oct 27, 2014 at 10:23 AM, Daniel Vratil <<a \
href="mailto:dvratil@redhat.com">dvratil@redhat.com</a>> wrote:<br> > > On \
Friday 24 of October 2014 15:51:59 Aleix Pol wrote:<br> > > > Hi,<br>
> > > I just pushed a new branch to get the project to compile with Qt5. \
[1]<br> > ><br>
> > The<br>
> ><br>
> > > branch is called qt5.<br>
> ><br>
> > Thanks, you rock!<br>
> ><br>
> > > Please Dan can you take a look and see how badly I messed up? :D<br>
> ><br>
> > Looks ok to me :-)<br>
> ><br>
> > Dan<br>
> ><br>
> > > Cheers!<br>
> > > Aleix<br>
> > ><br>
> > > [1]<br>
> ><br>
> > <a href="http://commits.kde.org/telepathy-logger-qt/594d2c32c1bd088e98f32a4b88500b5" \
target="_blank">http://commits.kde.org/telepathy-logger-qt/594d2c32c1bd088e98f32a4b88500b5</a><br>
> > f4><br>
> > > ffdc7e1<br>
><br>
</span><span class="">> Ok, so what do we do about that? Qt5 in master?<br>
> Who needs to be told?<br>
<br>
</span>I am not familiar with KTp release plans (sadly I haven't been around \
this<br> project much lately) - but if next release is going to be Qt5-based, the<br>
merging can happen at any point, after we solve the following:<br>
<br>
Version number: I made TelepathyLoggerQt versioning follow upstream<br>
(TelepathyLogger), but now we would have to diverge as 0.8 is Qt4 \
build...<br></blockquote><div>Sure :)</div><div> </div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <br>
Merge noqtglib: I've ported away from QtGLib on the KTp sprint in May, but \
the<br> branch did not get merged, because I....kinda forgot about it. Since it's \
an<br> ABI break, this is a good point to merge it. But could also happen after<br>
merging Qt 5 to master, so not really important at this point.<br></blockquote><div>I \
would say it's fine if you merge it right now in the qt5 branch.</div><div> \
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <br>
CI requirements: we now require TelepathyQt5, so we have to check with<br>
sysadmins first whether it is available on the CI. Apparently we have<br>
telepathy-qt4 builds on the CI, so we probably should ask them to add<br>
telepathy-qt5 builds and build against them (?).<br></blockquote><div>Sure, we \
actually need to take into account the CI for KTp altogether \
anyway...</div><div><br></div><div>Aleix </div></div></div></div>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic