'Re: Review Request 119064: Add a "Go online" button when offline'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Re: Review Request 119064: Add a "Go online" button when offline
From:       "Commit Hook" <null () kde ! org>
Date:       2014-07-02 9:51:49
Message-ID: 20140702095149.22336.96334 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119064/#review61468
-----------------------------------------------------------

This review has been submitted with commit f1ea23737a5276bfa7a88e934a588a9572986ada \
by Aleix Pol to branch frameworks.

- Commit Hook

On July 2, 2014, 12:30 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119064/
> -----------------------------------------------------------
> 
> (Updated July 2, 2014, 12:30 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> We're showing an empty view when we're offline. This should be improved, so I took \
> the fast and simple approach first. 
> 
> Diffs
> -----
> 
> contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml 826465a 
> 
> Diff: https://git.reviewboard.kde.org/r/119064/diff/
> 
> 
> Testing
> -------
> 
> It's simple and it works. I like it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119064/">https://git.reviewboard.kde.org/r/119064/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit f1ea23737a5276bfa7a88e934a588a9572986ada by Aleix Pol to branch \
frameworks.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On July 2nd, 2014, 12:30 a.m. UTC, Aleix Pol Gonzalez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated July 2, 2014, 12:30 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-desktop-applets
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We&#39;re showing an empty view when we&#39;re offline. This should be \
improved, so I took the fast and simple approach first.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It&#39;s simple and it works. I like it.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml <span \
style="color: grey">(826465a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119064/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 