[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 119052: Limit no. of characters of custom status displayed in context menu
From: "Commit Hook" <null () kde ! org>
Date: 2014-07-02 9:24:32
Message-ID: 20140702092432.22318.83833 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119052/#review61466
-----------------------------------------------------------
This review has been submitted with commit a57f7f6b38e0a963967285476a321136236b835e \
by Siddhartha Sahu to branch master.
- Commit Hook
On July 1, 2014, 7:32 a.m., Siddhartha Sahu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119052/
> -----------------------------------------------------------
>
> (Updated July 1, 2014, 7:32 a.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-desktop-applets
>
>
> Description
> -------
>
> Currently, the complete status message is used to create a menu entry, which means \
> very long menu entries sometimes. Extremely long status messages completely mess up \
> the context menu. This patch shortens the entries to max. 60 characters (arbitrary \
> limit).
>
> Diffs
> -----
>
> presence/src/presence-applet.cpp f44855a8278d49e8ee382bc5c501144ab9b274d1
>
> Diff: https://git.reviewboard.kde.org/r/119052/diff/
>
>
> Testing
> -------
>
> Longs entries are now shortened.
>
>
> Thanks,
>
> Siddhartha Sahu
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119052/">https://git.reviewboard.kde.org/r/119052/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit a57f7f6b38e0a963967285476a321136236b835e by Siddhartha Sahu to \
branch master.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On July 1st, 2014, 7:32 a.m. UTC, Siddhartha Sahu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Siddhartha Sahu.</div>
<p style="color: grey;"><i>Updated July 1, 2014, 7:32 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-desktop-applets
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, the complete status message is used to create a menu entry, \
which means very long menu entries sometimes. Extremely long status messages \
completely mess up the context menu. This patch shortens the entries to max. 60 \
characters (arbitrary limit). </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Longs entries are now shortened.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>presence/src/presence-applet.cpp <span style="color: \
grey">(f44855a8278d49e8ee382bc5c501144ab9b274d1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119052/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic