[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 112970: Save uniqueIdentifier instead of objectPath
From: "Daniele E. Domenichelli" <daniele.domenichelli () gmail ! com>
Date: 2013-11-25 13:43:16
Message-ID: 20131125134316.24601.78466 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112970/
-----------------------------------------------------------
(Updated Nov. 25, 2013, 1:43 p.m.)
Status
------
This change has been discarded.
Review request for Telepathy.
Repository: ktp-common-internals
Description
-------
uniqueIdentifier is guaranteed to be unique by telepathy, object paths coming from \
different service could hypotetically be non-unique, even though I believe that the \
specs require to append the uniqueIdentifier to "/org/freedesktop/Telepathy/"... \
anyway it is shorter and since it is the value returned as "account" from kpeople \
query, I believe it should be the same value saved in \
~/.local/share/telepathy/mission-control/accounts.cfg
Diffs
-----
KTp/Models/accounts-tree-proxy-model.cpp c6002948093a22ecff9149651d41a030df838aa3
KTp/Models/kpeopletranslationproxy.cpp a9bce378271006a9003c7757e49ba5b76ea97223
kpeople/nepomuk-feeder/abstract-storage.h 952b4e0f492ac679f34d687cc26a4f5dba7e2718
kpeople/nepomuk-feeder/account.h 4ab64abb4280e7217966a19bda27017353902886
kpeople/nepomuk-feeder/account.cpp 161ea40ae609165a609a545b08a8d202dad07c1c
kpeople/nepomuk-feeder/controller.cpp fa37b7e01734a2066261c3950d03f13ea034c02f
kpeople/nepomuk-feeder/nepomuk-storage.h 3b712da642b7c728195c20ebb4b5516de911715d
kpeople/nepomuk-feeder/nepomuk-storage.cpp 8e54a442ae7ee47ea93fb034cf73bc7469a03865 \
kpeople/nepomuk-feeder/tests/controller-test.h \
cdf690ce3b0adbddc6970a78abd0949bf0afaf03 \
kpeople/nepomuk-feeder/tests/controller-test.cpp \
aec56e2447dae41ec45f58c2971946b674c0aba9
Diff: http://git.reviewboard.kde.org/r/112970/diff/
Testing
-------
Switched a few times from objectPath to uniqueIdentifier, contacts are updated \
(tested with nepomuk shell), contact list still works
Thanks,
Daniele E. Domenichelli
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112970/">http://git.reviewboard.kde.org/r/112970/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniele E. Domenichelli.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2013, 1:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">uniqueIdentifier is guaranteed to be unique by telepathy, object paths \
coming from different service could hypotetically be non-unique, even though I \
believe that the specs require to append the uniqueIdentifier to \
"/org/freedesktop/Telepathy/"... anyway it is shorter and since it is the \
value returned as "account" from kpeople query, I believe it should be the \
same value saved in ~/.local/share/telepathy/mission-control/accounts.cfg</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Switched a few times from objectPath to uniqueIdentifier, contacts are \
updated (tested with nepomuk shell), contact list still works</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Models/accounts-tree-proxy-model.cpp <span style="color: \
grey">(c6002948093a22ecff9149651d41a030df838aa3)</span></li>
<li>KTp/Models/kpeopletranslationproxy.cpp <span style="color: \
grey">(a9bce378271006a9003c7757e49ba5b76ea97223)</span></li>
<li>kpeople/nepomuk-feeder/abstract-storage.h <span style="color: \
grey">(952b4e0f492ac679f34d687cc26a4f5dba7e2718)</span></li>
<li>kpeople/nepomuk-feeder/account.h <span style="color: \
grey">(4ab64abb4280e7217966a19bda27017353902886)</span></li>
<li>kpeople/nepomuk-feeder/account.cpp <span style="color: \
grey">(161ea40ae609165a609a545b08a8d202dad07c1c)</span></li>
<li>kpeople/nepomuk-feeder/controller.cpp <span style="color: \
grey">(fa37b7e01734a2066261c3950d03f13ea034c02f)</span></li>
<li>kpeople/nepomuk-feeder/nepomuk-storage.h <span style="color: \
grey">(3b712da642b7c728195c20ebb4b5516de911715d)</span></li>
<li>kpeople/nepomuk-feeder/nepomuk-storage.cpp <span style="color: \
grey">(8e54a442ae7ee47ea93fb034cf73bc7469a03865)</span></li>
<li>kpeople/nepomuk-feeder/tests/controller-test.h <span style="color: \
grey">(cdf690ce3b0adbddc6970a78abd0949bf0afaf03)</span></li>
<li>kpeople/nepomuk-feeder/tests/controller-test.cpp <span style="color: \
grey">(aec56e2447dae41ec45f58c2971946b674c0aba9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112970/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic