[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 111683: Make TelepathyLoggerQt an optional dependency of ktp-text-ui
From: "Daniele E. Domenichelli" <daniele.domenichelli () gmail ! com>
Date: 2013-07-25 15:27:43
Message-ID: 20130725152743.14140.93404 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111683/#review36492
-----------------------------------------------------------
The idea and the implementation look good to me, I wonder if it is worth to move this \
in ktp-common-internal, in order to avoid to ifdef everything in the other packages
- Daniele E. Domenichelli
On July 25, 2013, 2:43 p.m., Dan Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111683/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 2:43 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Because LogManager is asynchronous, #ifdef'ing it's usage would be very messy, so \
> instead I introduced a dummy implementation which only emits fetched() signal with \
> empty list when building without TpLoggerQt. Given it's just a temporary measure, \
> this seems to be the least intrusive approach.
>
> Diffs
> -----
>
> CMakeLists.txt 1d16dc7
> lib/CMakeLists.txt 80a3eff
> lib/chat-widget.cpp 74cee48
> lib/logmanager.h 3f4a2f1
> lib/logmanager.cpp 6cd1aec
> lib/logmanager_dummy.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/111683/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Vrátil
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111683/">http://git.reviewboard.kde.org/r/111683/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The idea and the \
implementation look good to me, I wonder if it is worth to move this in \
ktp-common-internal, in order to avoid to ifdef everything in the other \
packages</pre> <br />
<p>- Daniele E.</p>
<br />
<p>On July 25th, 2013, 2:43 p.m. UTC, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated July 25, 2013, 2:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Because LogManager is asynchronous, #ifdef'ing it's usage would \
be very messy, so instead I introduced a dummy implementation which only emits \
fetched() signal with empty list when building without TpLoggerQt. Given it's \
just a temporary measure, this seems to be the least intrusive approach. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1d16dc7)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(80a3eff)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(74cee48)</span></li>
<li>lib/logmanager.h <span style="color: grey">(3f4a2f1)</span></li>
<li>lib/logmanager.cpp <span style="color: grey">(6cd1aec)</span></li>
<li>lib/logmanager_dummy.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111683/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic