'Re: Review Request 111091: Add "Always Ask" option for filetransfer destination directory'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Re: Review Request 111091: Add "Always Ask" option for filetransfer destination directory
From:       "Daniele E. Domenichelli" <daniele.domenichelli () gmail ! com>
Date:       2013-06-24 9:49:07
Message-ID: 20130624094907.17589.35665 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111091/#review34956
-----------------------------------------------------------

Ship it!

Ship It!

- Daniele E. Domenichelli

On June 24, 2013, 9:03 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111091/
> -----------------------------------------------------------
> 
> (Updated June 24, 2013, 9:03 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Implements support for "Always Ask" for filetransfer destination directory option.
> 
> The hack with __k__onDownloadDirectoryCancelled() is necessary because \
> KDirSelectDialog::result() always returns 0 and buttonClicked() signal is emitted \
> even when "New Folder" button is clicked and handling that would make the code more \
> complicated. 
> 
> This addresses bug 295937.
> http://bugs.kde.org/show_bug.cgi?id=295937
> 
> 
> Diffs
> -----
> 
> src/filetransfer-handler.cpp 74c701e 
> src/handle-incoming-file-transfer-channel-job.h d5e53c4 
> src/handle-incoming-file-transfer-channel-job.cpp 7a15237 
> 
> Diff: http://git.reviewboard.kde.org/r/111091/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111091/">http://git.reviewboard.kde.org/r/111091/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Daniele E.</p>

<br />
<p>On June 24th, 2013, 9:03 a.m. UTC, Dan Vrátil wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>

<p style="color: grey;"><i>Updated June 24, 2013, 9:03 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implements support for &quot;Always Ask&quot; for filetransfer \
destination directory option.

The hack with __k__onDownloadDirectoryCancelled() is necessary because \
KDirSelectDialog::result() always returns 0 and buttonClicked() signal is emitted \
even when &quot;New Folder&quot; button is clicked and handling that would make the \
code more complicated.

</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=295937">295937</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/filetransfer-handler.cpp <span style="color: grey">(74c701e)</span></li>

 <li>src/handle-incoming-file-transfer-channel-job.h <span style="color: \
grey">(d5e53c4)</span></li>

 <li>src/handle-incoming-file-transfer-channel-job.cpp <span style="color: \
grey">(7a15237)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111091/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 