[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 111128: Add CMake files to find libkpeople
From: "Daniele E. Domenichelli" <daniele.domenichelli () gmail ! com>
Date: 2013-06-19 17:24:40
Message-ID: 20130619172440.12208.54252 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 19, 2013, 5:05 p.m., Aleix Pol Gonzalez wrote:
> > KPeople is already installing a FindKPeople.cmake file already.
> >
> > Also it's a bit more complete that this one, since it offers \
> > KPEOPLE_WIDGETS_LIBRARY and some others IIRC.
>
> David Edmundson wrote:
> oh..that's handy!
>
> Daniele E. Domenichelli wrote:
> That's wrong, it should install a KPeopleConfig.cmake and some other stuff, and it \
> won't require the FindKPeople.cmake
see http://cmake.org/Wiki/CMake/Tutorials/Packaging
- Daniele E.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111128/#review34689
-----------------------------------------------------------
On June 19, 2013, 4:13 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111128/
> -----------------------------------------------------------
>
> (Updated June 19, 2013, 4:13 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Add CMake files to find libkpeople
>
>
> Diffs
> -----
>
> CMakeLists.txt a83069d59fed945d04560662e3a307ef33b28332
> cmake/modules/FindKPeople.cmake PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/111128/diff/
>
>
> Testing
> -------
>
> I get
> -----------------------------------------------------------------------------
> -- The following external packages were located on your system.
> -- This installation will have the extra features provided by these packages.
> -----------------------------------------------------------------------------
> * KPeople - Support for KDE Contact Aggregation
>
> ---------------------------------------------------------
>
>
> scummos gets
>
> [17:11] <scummos> -- The following OPTIONAL packages could NOT be located on your \
> system. [17:11] <scummos> -- Consider installing them to enable more features from \
> this software. [17:11] <scummos> \
> ----------------------------------------------------------------------------- \
> [17:11] <scummos> * KPeople <https://projects.kde.org/libkpeople>
>
> Thanks,
>
> David Edmundson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111128/">http://git.reviewboard.kde.org/r/111128/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 19th, 2013, 5:05 p.m. UTC, <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KPeople is already installing a FindKPeople.cmake file already.
Also it's a bit more complete that this one, since it offers \
KPEOPLE_WIDGETS_LIBRARY and some others IIRC.</pre> </blockquote>
<p>On June 19th, 2013, 5:06 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">oh..that's \
handy!</pre> </blockquote>
<p>On June 19th, 2013, 5:21 p.m. UTC, <b>Daniele E. Domenichelli</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's wrong, it \
should install a KPeopleConfig.cmake and some other stuff, and it won't require \
the FindKPeople.cmake</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see \
http://cmake.org/Wiki/CMake/Tutorials/Packaging</pre> <br />
<p>- Daniele E.</p>
<br />
<p>On June 19th, 2013, 4:13 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated June 19, 2013, 4:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add CMake files to find libkpeople</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I get
-----------------------------------------------------------------------------
-- The following external packages were located on your system.
-- This installation will have the extra features provided by these packages.
-----------------------------------------------------------------------------
* KPeople - Support for KDE Contact Aggregation
---------------------------------------------------------
scummos gets
[17:11] <scummos> -- The following OPTIONAL packages could NOT be located on \
your system. [17:11] <scummos> -- Consider installing them to enable more \
features from this software. [17:11] <scummos> \
----------------------------------------------------------------------------- [17:11] \
<scummos> * KPeople <https://projects.kde.org/libkpeople></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(a83069d59fed945d04560662e3a307ef33b28332)</span></li>
<li>cmake/modules/FindKPeople.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111128/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic