[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 110236: Remove pointless call to model index parent to count top level items
From: "Daniele E. Domenichelli" <daniele.domenichelli () gmail ! com>
Date: 2013-04-29 11:57:42
Message-ID: 20130429115742.20863.39030 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 29, 2013, 6:57 a.m., Daniele E. Domenichelli wrote:
> > global-presence-chooser.cpp, line 95
> > <http://git.reviewboard.kde.org/r/110236/diff/1/?file=141318#file141318line95>
> >
> > Isn't QModelIndex() and invalid index?
>
> David Edmundson wrote:
> Yes. And the parent of a top level item is an invalid index.
>
> If we look at rowCount we do:
> if (parent.isValid) {return 0;}
>
> we want to pass an invalid index to get the list row count.
I still don't get this, sorry...
If "rowCount(QModelIndex())" returns 0, "rowCount(QModelIndex())-1" is always "-1", \
or am I missing something?
- Daniele E.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110236/#review31725
-----------------------------------------------------------
On April 29, 2013, 1:56 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110236/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 1:56 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Remove pointless call to model index parent to count top level items
>
> BUG: 304085
>
>
> Diffs
> -----
>
> global-presence-chooser.cpp f5d59399a904195121ebac7266bef4176ac82bfb
>
> Diff: http://git.reviewboard.kde.org/r/110236/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110236/">http://git.reviewboard.kde.org/r/110236/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 29th, 2013, 6:57 a.m. UTC, <b>Daniele E. \
Domenichelli</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110236/diff/1/?file=141318#file141318line95" \
style="color: black; font-weight: bold; text-decoration: \
underline;">global-presence-chooser.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
PresenceModelExtended::rowCount(const QModelIndex &parent) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">95</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> \
<span class="p">(</span><span class="n">index</span><span class="p">.</span><span \
class="n">row</span><span class="p">()</span> <span class="o">==</span> <span \
class="n">rowCount</span><span class="p">(</span><span class="n"><span \
class="hl">i</span>ndex</span><span class="p"><span class="hl">.</span></span><span \
class="n"><span class="hl">parent</span></span><span class="p">())</span><span \
class="o">-</span><span class="mi">1</span><span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">95</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="n">index</span><span class="p">.</span><span \
class="n">row</span><span class="p">()</span> <span class="o">==</span> <span \
class="n">rowCount</span><span class="p">(</span><span class="n"><span \
class="hl">QModelI</span>ndex</span><span class="p">())</span><span \
class="o">-</span><span class="mi">1</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Isn't QModelIndex() \
and invalid index?</pre> </blockquote>
<p>On April 29th, 2013, 10:39 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes. And the parent of a \
top level item is an invalid index.
If we look at rowCount we do:
if (parent.isValid) {return 0;}
we want to pass an invalid index to get the list row count.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I still \
don't get this, sorry... If "rowCount(QModelIndex())" returns 0, \
"rowCount(QModelIndex())-1" is always "-1", or am I missing \
something? </pre>
<br />
<p>- Daniele E.</p>
<br />
<p>On April 29th, 2013, 1:56 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated April 29, 2013, 1:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove pointless call to model index parent to count top level items
BUG: 304085</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>global-presence-chooser.cpp <span style="color: \
grey">(f5d59399a904195121ebac7266bef4176ac82bfb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110236/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic