[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 110004: Loose the word "tube" in approver; use just one notification for unknown
From: "Daniele E. Domenichelli" <daniele.domenichelli () gmail ! com>
Date: 2013-04-14 23:44:29
Message-ID: 20130414234429.12507.71140 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110004/#review31034
-----------------------------------------------------------
Sorry if I'm late and it was already committed, but I have a comment...
src/tubechannelapprover.cpp
<http://git.reviewboard.kde.org/r/110004/#comment23085>
Perhaps the notification should display serviceName as well, so that even if you \
have a service that don't install a .desktop file, you can still see its name. Here \
"unknown service" means "a tube with a service name that is unknown to the approver", \
but the user might know what the service name means, so I believe it's worth \
displaying it.
- Daniele E. Domenichelli
On April 14, 2013, 5:54 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110004/
> -----------------------------------------------------------
>
> (Updated April 14, 2013, 5:54 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> If I understand the original code correctly - if there are no services found, it \
> shows "unknown tube" notification. If there are services but none for the given \
> tube, it shows "user wants to start a remote service" notification, but these cases \
> are the same - ie. no service found for the given tube, so let's simplify the logic \
> and loose the word "tube".
>
> Diffs
> -----
>
> src/tubechannelapprover.cpp cc651e0
>
> Diff: http://git.reviewboard.kde.org/r/110004/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110004/">http://git.reviewboard.kde.org/r/110004/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry if I'm late \
and it was already committed, but I have a comment...</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110004/diff/1/?file=138639#file138639line76" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/tubechannelapprover.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">TubeChannelApprover::TubeChannelApprover(const Tp::TubeChannelPtr& channel, \
QObject* parent):</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">75</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">showNotification</span><span class="p">(</span><span \
class="n">i18n</span><span class="p">(</span><span class="s">"Incoming \
Request"</span><span class="p">),</span> <span class="n">i18n</span><span \
class="p">(</span><span class="s">"%1 wants to start a remote service with \
you"</span><span class="p">),</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">71</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">showNotification</span><span class="p">(</span><span \
class="n">i18n</span><span class="p">(</span><span class="s">"Unknown Incoming \
Connection"</span><span class="p">),</span></pre></td> </tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">76</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n"><span class="hl">QLatin1String</span></span><span class="p"><span \
class="hl">(</span></span><span class="s"><span \
class="hl">"dialog-warning"</span></span><span class="p"><span \
class="hl">)</span>,</span> <span class="n">channel</span><span \
class="o">-></span><span class="n">initiatorContact</span><span class="p">()<span \
class="hl">);</span></span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">72</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n"><span \
class="hl">i18n</span></span><span class="p"><span class="hl">(</span></span><span \
class="s"><span class="hl">"%1 wants to start an unknown service with \
you"</span></span><span class="p">,</span> <span class="n">channel</span><span \
class="o">-></span><span class="n">initiatorContact</span><span \
class="p">()</span><span class="o"><span class="hl">-></span></span><span \
class="n"><span class="hl">alias</span></span><span class="p"><span \
class="hl">()),</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Perhaps the \
notification should display serviceName as well, so that even if you have a service \
that don't install a .desktop file, you can still see its name. Here \
"unknown service" means "a tube with a service name that is unknown to \
the approver", but the user might know what the service name means, so I believe \
it's worth displaying it.</pre> </div>
<br />
<p>- Daniele E.</p>
<br />
<p>On April 14th, 2013, 5:54 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated April 14, 2013, 5:54 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If I understand the original code correctly - if there are no services \
found, it shows "unknown tube" notification. If there are services but none \
for the given tube, it shows "user wants to start a remote service" \
notification, but these cases are the same - ie. no service found for the given tube, \
so let's simplify the logic and loose the word "tube".</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/tubechannelapprover.cpp <span style="color: grey">(cc651e0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110004/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic