[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 109852: Restore printing tp-qt version and fix it for debug kdelibs
From: "Daniele E. Domenichelli" <daniele.domenichelli () gmail ! com>
Date: 2013-04-04 13:31:13
Message-ID: 20130404133113.31405.76866 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 4, 2013, 11:20 a.m., David Edmundson wrote:
> > What Alex is trying to say is "Ship it!"
> >
> > Do we want to backport it? I'm more skeptical about doing that till have a bit \
> > more testing.
>
> Aleix Pol Gonzalez wrote:
> Well, the current implementation has crashes, I'm skeptical about keeping that :P.
>
> David Edmundson wrote:
> No it doesn't.
>
> It used to crash. Then I removed the code before 0.6. This patch restores it in a \
> less crashy way.
So I'd say either apply the patch in 0.6 or remove the extra string and the extra \
check in 0.6 and apply to master. Not a very big deal but it does help a lot in \
spotting telepathy-qt warnings
- Daniele E.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109852/#review30357
-----------------------------------------------------------
On April 4, 2013, 9:14 a.m., Daniele E. Domenichelli wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109852/
> -----------------------------------------------------------
>
> (Updated April 4, 2013, 9:14 a.m.)
>
>
> Review request for Telepathy, Aleix Pol Gonzalez and David Edmundson.
>
>
> Description
> -------
>
> Restore printing tp-qt version and fix it for debug kdelibs
>
> Commit 6cbefb04441bab0d25dde78d95a2adee4d163fd5 "Prevent crashes with
> debug kdelibs" should probably have been reverting commit
> 58d7eb5a461bc597455065da3a4cd813e4f0a15a "Print tp-qt library name and
> version in tp-qt debug"
>
> If the line cannot be printed, it doesn't make sense to keep the extra
> string and the extra check.
>
> Anyway the problem seem to come with a Q_ASSERT_X in kdelibs that
> searches for "(" (see kdelibs kdecore/io/kdebug.cpp.html:577)
>
> This patch restore the previous behaviour, and should fix the crash.
>
> Also add a ":" to the string, because I realized that everything that
> comes before the white space is stripped away, so now it prints
> something like "tp-qt:0.9.3.1"
>
>
> Diffs
> -----
>
> KTp/debug.cpp adad3fbad2456379d0f0775fc701904316479f68
>
> Diff: http://git.reviewboard.kde.org/r/109852/diff/
>
>
> Testing
> -------
>
> I don't have kdelibs built with debug, so please test it if you have.
>
>
> Thanks,
>
> Daniele E. Domenichelli
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109852/">http://git.reviewboard.kde.org/r/109852/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 4th, 2013, 11:20 a.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">What Alex is trying to say is "Ship it!"
Do we want to backport it? I'm more skeptical about doing that till have a bit \
more testing. </pre> </blockquote>
<p>On April 4th, 2013, 11:22 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, the current \
implementation has crashes, I'm skeptical about keeping that :P.</pre> \
</blockquote>
<p>On April 4th, 2013, 11:23 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No it doesn't.
It used to crash. Then I removed the code before 0.6. This patch restores it in a \
less crashy way.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So I'd say either \
apply the patch in 0.6 or remove the extra string and the extra check in 0.6 and \
apply to master. Not a very big deal but it does help a lot in spotting telepathy-qt \
warnings</pre> <br />
<p>- Daniele E.</p>
<br />
<p>On April 4th, 2013, 9:14 a.m. UTC, Daniele E. Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy, Aleix Pol Gonzalez and David Edmundson.</div>
<div>By Daniele E. Domenichelli.</div>
<p style="color: grey;"><i>Updated April 4, 2013, 9:14 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Restore printing tp-qt version and fix it for debug kdelibs
Commit 6cbefb04441bab0d25dde78d95a2adee4d163fd5 "Prevent crashes with
debug kdelibs" should probably have been reverting commit
58d7eb5a461bc597455065da3a4cd813e4f0a15a "Print tp-qt library name and
version in tp-qt debug"
If the line cannot be printed, it doesn't make sense to keep the extra
string and the extra check.
Anyway the problem seem to come with a Q_ASSERT_X in kdelibs that
searches for "(" (see kdelibs kdecore/io/kdebug.cpp.html:577)
This patch restore the previous behaviour, and should fix the crash.
Also add a ":" to the string, because I realized that everything that
comes before the white space is stripped away, so now it prints
something like "tp-qt:0.9.3.1"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I don't have kdelibs built with debug, so please test it if you \
have.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/debug.cpp <span style="color: \
grey">(adad3fbad2456379d0f0775fc701904316479f68)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109852/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic