[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 109699: Simplify the behavior of the main UI file in the chat plasmoid
From: "Lasath Fernando" <kde () lasath ! org>
Date: 2013-03-25 2:56:55
Message-ID: 20130325025655.29630.25976 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109699/#review29823
-----------------------------------------------------------
Ship it!
Ship It!
- Lasath Fernando
On March 25, 2013, 2:18 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109699/
> -----------------------------------------------------------
>
> (Updated March 25, 2013, 2:18 a.m.)
>
>
> Review request for Plasma and Telepathy.
>
>
> Description
> -------
>
> These are some ideas I got from the last commit, let's see:
> * Provide a bigger minimum size, I thought it would never get to the minimum but it \
> does sometimes, so we can better give a bigger minimum (which is still too small \
> for a proper usage).
> * Rename preferredWidth/Height -> implicit*. It seems like it's the proper way to \
> call these.
> * When the plasmoid is empty, offer an empty preferred (uh implicit) size.
>
>
> Diffs
> -----
>
> chat/org.kde.ktp-chat/contents/ui/main.qml 1ee042a
>
> Diff: http://git.reviewboard.kde.org/r/109699/diff/
>
>
> Testing
> -------
>
> Tested it in plasma-desktop (it's very hard to test sizes with plasmoidviewer and \
> such), I still have the Icon Tasks eating up my space, but I guess I have to debug \
> other code to get around that. At least now it doesn't get as squeezed.
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109699/">http://git.reviewboard.kde.org/r/109699/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Lasath</p>
<br />
<p>On March 25th, 2013, 2:18 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Telepathy.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated March 25, 2013, 2:18 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">These are some ideas I got from the last commit, \
let's see:
* Provide a bigger minimum size, I thought it would never get to the minimum but it \
does sometimes, so we can better give a bigger minimum (which is still too small for \
a proper usage).
* Rename preferredWidth/Height -> implicit*. It seems like it's the proper way \
to call these.
* When the plasmoid is empty, offer an empty preferred (uh implicit) size.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested it in plasma-desktop (it's very hard to test sizes with \
plasmoidviewer and such), I still have the Icon Tasks eating up my space, but I guess \
I have to debug other code to get around that. At least now it doesn't get as \
squeezed.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>chat/org.kde.ktp-chat/contents/ui/main.qml <span style="color: \
grey">(1ee042a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109699/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic