[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid
From: "Marco Martin" <notmart () gmail ! com>
Date: 2013-03-21 22:23:27
Message-ID: 20130321222327.28956.28670 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 21, 2013, 6:54 p.m., David Edmundson wrote:
> > I'm very much against shipping any patches if we don't know why it fixes it. From \
> > what I can see from declarative/declarativeitemcontainer.cpp it just sets the \
> > minimumWidth to it... which I would have thought it would be doing anyway when we \
> > set the minimumWidth.
> > Any documentation on implicitWidth, preferredWidth, minimumWidth and width would \
> > be incredibly useful.
> > Given the proximity to the deadline and your testing I can't see this breaking \
> > anything, so ship it if you're confident with it.
meh, browser ate my previous comment :/
i was saying: declarativeitemcontainer.cpp is used only when the item is in a Dialog \
(in the popup) the root qml item is contained in a Plasma::DeclarativeWidget from \
libplasma
the minimum/implicit/maximum sizes of the root qml item gets exported as \
minimumSize,preferredSize and maximumSize respectively of the qgraphicswidget, \
therefore minimum,preferred and maximum of the Applet that is in the linear layout of \
the panel.
so, the documentation that applies is
http://qt-project.org/doc/qt-4.8/qgraphicslayoutitem.html
http://qt-project.org/doc/qt-4.8/qgraphicslinearlayout.html
basically minimum width: the layout will never resize the applet less than that, \
maximum width: the layout will never resize the applet more than that
preferred (in qml they decided to rename it to implicit but same thing) the layout \
will try to give it that size, but will still give it a different size when needed
so if as minimum, implicit and maximum you have 12, 56, 100 respectively, the layout \
will try to make it 56 pixels wide, but can decide to give it a different width, but \
never less than 12 and never more than 100
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109648/#review29651
-----------------------------------------------------------
On March 21, 2013, 5:37 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109648/
> -----------------------------------------------------------
>
> (Updated March 21, 2013, 5:37 p.m.)
>
>
> Review request for Plasma, Telepathy and David Edmundson.
>
>
> Description
> -------
>
> Implements those 2 properties, aliasing to the similar preferredWidth/Height.
>
> When I have Icon-Only tasks + Chat plasmoid in a panel, their growth rendered \
> unpredictable. Implementing the implicit seems to solve this problem.
>
> Diffs
> -----
>
> chat/org.kde.ktp-chat/contents/ui/main.qml e11269e
>
> Diff: http://git.reviewboard.kde.org/r/109648/diff/
>
>
> Testing
> -------
>
> I was reproducing the problem regularly since a couple of days, then now I cannot \
> reproduce anymore.
> There's no testing per se, though...
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109648/">http://git.reviewboard.kde.org/r/109648/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 21st, 2013, 6:54 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm very much against shipping any patches if we don't know why \
it fixes it. From what I can see from declarative/declarativeitemcontainer.cpp it \
just sets the minimumWidth to it... which I would have thought it would be doing \
anyway when we set the minimumWidth.
Any documentation on implicitWidth, preferredWidth, minimumWidth and width would be \
incredibly useful.
Given the proximity to the deadline and your testing I can't see this breaking \
anything, so ship it if you're confident with it.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">meh, browser ate my \
previous comment :/ i was saying: declarativeitemcontainer.cpp is used only when the \
item is in a Dialog (in the popup) the root qml item is contained in a \
Plasma::DeclarativeWidget from libplasma
the minimum/implicit/maximum sizes of the root qml item gets exported as \
minimumSize,preferredSize and maximumSize respectively of the qgraphicswidget, \
therefore minimum,preferred and maximum of the Applet that is in the linear layout of \
the panel.
so, the documentation that applies is
http://qt-project.org/doc/qt-4.8/qgraphicslayoutitem.html
http://qt-project.org/doc/qt-4.8/qgraphicslinearlayout.html
basically minimum width: the layout will never resize the applet less than that, \
maximum width: the layout will never resize the applet more than that
preferred (in qml they decided to rename it to implicit but same thing) the layout \
will try to give it that size, but will still give it a different size when needed
so if as minimum, implicit and maximum you have 12, 56, 100 respectively, the layout \
will try to make it 56 pixels wide, but can decide to give it a different width, but \
never less than 12 and never more than 100</pre> <br />
<p>- Marco</p>
<br />
<p>On March 21st, 2013, 5:37 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Telepathy and David Edmundson.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated March 21, 2013, 5:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implements those 2 properties, aliasing to the similar \
preferredWidth/Height.
When I have Icon-Only tasks + Chat plasmoid in a panel, their growth rendered \
unpredictable. Implementing the implicit seems to solve this problem.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I was reproducing the problem regularly since a couple of days, then now \
I cannot reproduce anymore.
There's no testing per se, though...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>chat/org.kde.ktp-chat/contents/ui/main.qml <span style="color: \
grey">(e11269e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109648/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic