[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Pinned people change overtime
From: Aleix Pol <aleixpol () kde ! org>
Date: 2013-02-19 23:31:53
Message-ID: CACcA1RrT=F-da-85Oc5zxu9bvqRyi9+fipUhGxvD=niWROtqJA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
no, I'll report it later, I'll try not to forget :)
On Tue, Feb 19, 2013 at 2:40 PM, David Edmundson <david@davidedmundson.co.uk
> wrote:
> BTW, is there a bug report on this?
>
>
> On Tue, Feb 19, 2013 at 1:21 PM, David Edmundson <
> david@davidedmundson.co.uk> wrote:
>
>>
>>
>> On Tue, Feb 19, 2013 at 12:31 PM, George Kiagiadakis <
>> kiagiadakis.george@gmail.com> wrote:
>>
>>> On Tue, Feb 19, 2013 at 2:24 PM, Aleix Pol <aleixpol@kde.org> wrote:
>>> > Hi,
>>> > I'm having a bit of a weird problem, since it's a bit long to explain,
>>> I
>>> > figured it would be better to explain it over the mailing list.
>>> >
>>> > As you'll know, we have this pinned contacts in the chat plasmoid. It
>>> stores
>>> > a KTP::ContactPtr and when I click the button I start a chat with this
>>> > contact.
>>> > Now the problem that I'm having is that when using it in my system I
>>> found
>>> > out that, after putting my laptop on suspend mode, when I click the
>>> pinned
>>> > contact a chat gets started with someone else.
>>> >
>>> > Do you think it could be that there's no identity integrity after an
>>> > offline/online cycle?
>>> > How do you think this should be fixed?
>>> >
>>>
>>> I think you shouldn't be storing ContactPtr. Contact objects are part
>>> of a certain Connection, so when the connection changes, weird things
>>> are likely to happen. You should store the contact id instead.
>>>
>>
>> A contact object should not be changing what it represents when a
>> connection resets.
>> I don't think that is the case, otherwise we'd be getting a lot more
>> errors elsewhere. Text-ui retains a ContactPtr after going offline. It
>> remains valid.
>>
>> Generally after a reset the original Tp::ContactPtr becomes useless; any
>> calls to manager() return 0 and it stops getting updated but it doesn't
>> turn into a different contact.
>>
>> I would suspect the problem is in the
>> pinned-contacts-model/conversations-model before investigating elsewhere.
>> That entire area has been under a lot of development on top of experimental
>> code and needs a really good tidy up.
>>
>> David
>>
>>
>>
>
> _______________________________________________
> KDE-Telepathy mailing list
> KDE-Telepathy@kde.org
> https://mail.kde.org/mailman/listinfo/kde-telepathy
>
>
[Attachment #5 (text/html)]
no, I'll report it later, I'll try not to forget :)<br><br><div \
class="gmail_quote">On Tue, Feb 19, 2013 at 2:40 PM, David Edmundson <span \
dir="ltr"><<a href="mailto:david@davidedmundson.co.uk" \
target="_blank">david@davidedmundson.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">BTW, is there a bug report on this?<div class="HOEnZb"><div \
class="h5"><br><br><div class="gmail_quote">On Tue, Feb 19, 2013 at 1:21 PM, David \
Edmundson <span dir="ltr"><<a href="mailto:david@davidedmundson.co.uk" \
target="_blank">david@davidedmundson.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><br><br><div class="gmail_quote"><div>On Tue, Feb 19, 2013 at \
12:31 PM, George Kiagiadakis <span dir="ltr"><<a \
href="mailto:kiagiadakis.george@gmail.com" \
target="_blank">kiagiadakis.george@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div><div>On Tue, Feb 19, 2013 at 2:24 PM, Aleix Pol <<a \
href="mailto:aleixpol@kde.org" target="_blank">aleixpol@kde.org</a>> wrote:<br>
> Hi,<br>
> I'm having a bit of a weird problem, since it's a bit long to explain, \
I<br> > figured it would be better to explain it over the mailing list.<br>
><br>
> As you'll know, we have this pinned contacts in the chat plasmoid. It \
stores<br> > a KTP::ContactPtr and when I click the button I start a chat with \
this<br> > contact.<br>
> Now the problem that I'm having is that when using it in my system I \
found<br> > out that, after putting my laptop on suspend mode, when I click the \
pinned<br> > contact a chat gets started with someone else.<br>
><br>
> Do you think it could be that there's no identity integrity after an<br>
> offline/online cycle?<br>
> How do you think this should be fixed?<br>
><br>
<br>
</div></div>I think you shouldn't be storing ContactPtr. Contact objects are \
part<br> of a certain Connection, so when the connection changes, weird things<br>
are likely to happen. You should store the contact id \
instead.<br></blockquote><div><br></div></div><div>A contact object should not be \
changing what it represents when a connection resets.</div><div>I don't think \
that is the case, otherwise we'd be getting a lot more errors elsewhere. Text-ui \
retains a ContactPtr after going offline. It remains valid. </div>
<div><br></div><div>Generally after a reset the original Tp::ContactPtr becomes \
useless; any calls to manager() return 0 and it stops getting updated but it \
doesn't turn into a different contact.</div><div><br></div>
<div>
I would suspect the problem is in the pinned-contacts-model/conversations-model \
before investigating elsewhere. That entire area has been under a lot of development \
on top of experimental code and needs a really good tidy up.</div>
<span><font color="#888888">
<div><br></div><div>David</div><div><br></div><div><br></div></font></span></div>
</blockquote></div><br>
</div></div><br>_______________________________________________<br>
KDE-Telepathy mailing list<br>
<a href="mailto:KDE-Telepathy@kde.org">KDE-Telepathy@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-telepathy" \
target="_blank">https://mail.kde.org/mailman/listinfo/kde-telepathy</a><br> \
<br></blockquote></div><br>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic