[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 108780: .desktop-based tubes channel approver
From: Dan_Vrátil <dvratil () redhat ! com>
Date: 2013-02-05 12:23:58
Message-ID: 20130205122358.21817.2051 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108780/
-----------------------------------------------------------
(Updated Feb. 5, 2013, 1:23 p.m.)
Review request for Telepathy.
Changes
-------
- add X-KTp-Preferred-Handler to .desktop files
- remove "tube" from public strings
- delete the approver when channel is invalidated
Description
-------
Lets see if it really works :)
Note that the 'Accept' and 'Reject' buttons in Plasma notifications don't work \
because of https://bugs.kde.org/show_bug.cgi?id=314357 , you have to use the \
KNotifierItem icon that appears in systray.
Once this gets committed I'll push respective .desktop files for kwhiteboard
This addresses bug 301331.
http://bugs.kde.org/show_bug.cgi?id=301331
Diffs (updated)
-----
CMakeLists.txt 8b29de7
data/ssh.service PRE-CREATION
ktp-approver.service PRE-CREATION
src/CMakeLists.txt a1ce660
src/approverdaemon.cpp 776a0a2
src/channelapprover.cpp 5d4b02b
src/ktpapprovermodule.cpp db5c005
src/streamtubechannelapprover.h aefe992
src/streamtubechannelapprover.cpp 2a99670
src/textchannelapprover.cpp 0e06a01
src/tubechannelapprover.h PRE-CREATION
src/tubechannelapprover.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/108780/diff/
Testing
-------
The best way to test is with KWhiteboard. To do so create \
/usr/share/kde4/services/ktp/kwhiteboard.desktop:
[Desktop Entry]
Type=Service
X-KDE-ServiceTypes=KTpApprover
Name=KWhiteboard
Icon=applications-education
Comment=User %1 wants to start KWhiteboard session with you
X-KTp-ChannelType=org.freedesktop.Telepathy.Channel.Type.DBusTube
X-KTp-Service=org.kde.KWhiteboard
X-KTp-Cancellable=false
...run kbuildsycoca4, restart KDED, load approver module and ask someone to start \
KWhiteboard session with you.
Thanks,
Dan Vrátil
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108780/">http://git.reviewboard.kde.org/r/108780/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2013, 1:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> - add X-KTp-Preferred-Handler to .desktop files
- remove "tube" from public strings
- delete the approver when channel is invalidated</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Lets see if it really works :)
Note that the 'Accept' and 'Reject' buttons in Plasma notifications \
don't work because of https://bugs.kde.org/show_bug.cgi?id=314357 , you have to \
use the KNotifierItem icon that appears in systray.
Once this gets committed I'll push respective .desktop files for \
kwhiteboard</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The best way to test is with KWhiteboard. To do so create \
/usr/share/kde4/services/ktp/kwhiteboard.desktop:
[Desktop Entry]
Type=Service
X-KDE-ServiceTypes=KTpApprover
Name=KWhiteboard
Icon=applications-education
Comment=User %1 wants to start KWhiteboard session with you
X-KTp-ChannelType=org.freedesktop.Telepathy.Channel.Type.DBusTube
X-KTp-Service=org.kde.KWhiteboard
X-KTp-Cancellable=false
...run kbuildsycoca4, restart KDED, load approver module and ask someone to start \
KWhiteboard session with you.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=301331">301331</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(8b29de7)</span></li>
<li>data/ssh.service <span style="color: grey">(PRE-CREATION)</span></li>
<li>ktp-approver.service <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(a1ce660)</span></li>
<li>src/approverdaemon.cpp <span style="color: grey">(776a0a2)</span></li>
<li>src/channelapprover.cpp <span style="color: grey">(5d4b02b)</span></li>
<li>src/ktpapprovermodule.cpp <span style="color: grey">(db5c005)</span></li>
<li>src/streamtubechannelapprover.h <span style="color: grey">(aefe992)</span></li>
<li>src/streamtubechannelapprover.cpp <span style="color: \
grey">(2a99670)</span></li>
<li>src/textchannelapprover.cpp <span style="color: grey">(0e06a01)</span></li>
<li>src/tubechannelapprover.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tubechannelapprover.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108780/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic