--===============6125974338296272154== Content-Type: multipart/alternative; boundary="===============0307708945711775120==" --===============0307708945711775120== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > On Feb. 4, 2013, 8:52 p.m., David Edmundson wrote: > > CMakeLists.txt, line 14 > > > > > > I'd like to open a discussion: > > - should this be in common-internals instead? > > Dan Vrátil wrote: > This is a approver-specific service file so I don't see a reason why it should be in k-c-i > > David Edmundson wrote: > Is that true? > > I was under the impression the .desktop file would also be used in KTp::Actions for making dynamic menus. Meh, I forgot about this. Now it makes sense to move it. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108780/#review26641 ----------------------------------------------------------- On Feb. 4, 2013, 6:45 p.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108780/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2013, 6:45 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Lets see if it really works :) > > Note that the 'Accept' and 'Reject' buttons in Plasma notifications don't work because of https://bugs.kde.org/show_bug.cgi?id=314357 , you have to use the KNotifierItem icon that appears in systray. > > Once this gets committed I'll push respective .desktop files for kwhiteboard > > > This addresses bug 301331. > http://bugs.kde.org/show_bug.cgi?id=301331 > > > Diffs > ----- > > CMakeLists.txt 8b29de7 > data/ssh.service PRE-CREATION > ktp-approver.service PRE-CREATION > src/CMakeLists.txt a1ce660 > src/approverdaemon.cpp 776a0a2 > src/channelapprover.cpp 5d4b02b > src/ktpapprovermodule.cpp db5c005 > src/streamtubechannelapprover.h aefe992 > src/streamtubechannelapprover.cpp 2a99670 > src/textchannelapprover.cpp 0e06a01 > src/tubechannelapprover.h PRE-CREATION > src/tubechannelapprover.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/108780/diff/ > > > Testing > ------- > > The best way to test is with KWhiteboard. To do so create /usr/share/kde4/services/ktp/kwhiteboard.desktop: > > [Desktop Entry] > Type=Service > X-KDE-ServiceTypes=KTpApprover > Name=KWhiteboard > Icon=applications-education > Comment=User %1 wants to start KWhiteboard session with you > > X-KTp-ChannelType=org.freedesktop.Telepathy.Channel.Type.DBusTube > X-KTp-Service=org.kde.KWhiteboard > X-KTp-Cancellable=false > > ...run kbuildsycoca4, restart KDED, load approver module and ask someone to start KWhiteboard session with you. > > > Thanks, > > Dan Vrátil > > --===============0307708945711775120== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108780/

On February 4th, 2013, 8:52 p.m. CET, David Edmundson wrote:
CMakeLists.txt (Diff revision 1)
14
    data/ssh.service
I'd like to open a discussion:
 - should this be in common-internals instead?
On February 5th, 2013, 11:37 a.m. CET, Dan Vrátil wrote:
This is a approver-specific service file so I don't see a reason why it should be in k-c-i
On February 5th, 2013, 12:09 p.m. CET, David Edmundson wrote:
Is that true?

I was under the impression the .desktop file would also be used in KTp::Actions for making dynamic menus.

Meh, I forgot about this. Now it makes sense to move it.

- Dan

On February 4th, 2013, 6:45 p.m. CET, Dan Vrátil wrote:

Review request for Telepathy.

By Dan Vrátil.

Updated Feb. 4, 2013, 6:45 p.m.

Description

Lets see if it really works :)

Note that the 'Accept' and 'Reject' buttons in Plasma notifications don't work because of https://bugs.kde.org/show_bug.cgi?id=314357 , you have to use the KNotifierItem icon that appears in systray.

Once this gets committed I'll push respective .desktop files for kwhiteboard

Testing

The best way to test is with KWhiteboard. To do so create /usr/share/kde4/services/ktp/kwhiteboard.desktop:

[Desktop Entry]
Type=Service
X-KDE-ServiceTypes=KTpApprover
Name=KWhiteboard
Icon=applications-education
Comment=User %1 wants to start KWhiteboard session with you

X-KTp-ChannelType=org.freedesktop.Telepathy.Channel.Type.DBusTube
X-KTp-Service=org.kde.KWhiteboard
X-KTp-Cancellable=false

...run kbuildsycoca4, restart KDED, load approver module and ask someone to start KWhiteboard session with you.

Bugs: 301331

Diffs

CMakeLists.txt (8b29de7)
data/ssh.service (PRE-CREATION)
ktp-approver.service (PRE-CREATION)
src/CMakeLists.txt (a1ce660)
src/approverdaemon.cpp (776a0a2)
src/channelapprover.cpp (5d4b02b)
src/ktpapprovermodule.cpp (db5c005)
src/streamtubechannelapprover.h (aefe992)
src/streamtubechannelapprover.cpp (2a99670)
src/textchannelapprover.cpp (0e06a01)
src/tubechannelapprover.h (PRE-CREATION)
src/tubechannelapprover.cpp (PRE-CREATION)

--===============0307708945711775120==-- --===============6125974338296272154== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KDE-Telepathy mailing list KDE-Telepathy@kde.org https://mail.kde.org/mailman/listinfo/kde-telepathy --===============6125974338296272154==--