On February 4th, 2013, 7:52 p.m. UTC, David Edmundson wrote:
I'd like to open a discussion:
- should this be in common-internals instead?
On February 5th, 2013, 10:37 a.m. UTC, Dan Vrátil wrote:
This is a approver-specific service file so I don't see a reason why it should be in k-c-i
Is that true?
I was under the impression the .desktop file would also be used in KTp::Actions for making dynamic menus.
- David
On February 4th, 2013, 5:45 p.m. UTC, Dan Vrátil wrote:
|
Review request for Telepathy.
By Dan Vrátil.
Updated Feb. 4, 2013, 5:45 p.m.
Description
Lets see if it really works :)
Note that the 'Accept' and 'Reject' buttons in Plasma notifications don't work because of https://bugs.kde.org/show_bug.cgi?id=314357 , you have to use the KNotifierItem icon that appears in systray.
Once this gets committed I'll push respective .desktop files for kwhiteboard
|
Testing
The best way to test is with KWhiteboard. To do so create /usr/share/kde4/services/ktp/kwhiteboard.desktop:
[Desktop Entry]
Type=Service
X-KDE-ServiceTypes=KTpApprover
Name=KWhiteboard
Icon=applications-education
Comment=User %1 wants to start KWhiteboard session with you
X-KTp-ChannelType=org.freedesktop.Telepathy.Channel.Type.DBusTube
X-KTp-Service=org.kde.KWhiteboard
X-KTp-Cancellable=false
...run kbuildsycoca4, restart KDED, load approver module and ask someone to start KWhiteboard session with you.
|
Diffs
- CMakeLists.txt (8b29de7)
- data/ssh.service (PRE-CREATION)
- ktp-approver.service (PRE-CREATION)
- src/CMakeLists.txt (a1ce660)
- src/approverdaemon.cpp (776a0a2)
- src/channelapprover.cpp (5d4b02b)
- src/ktpapprovermodule.cpp (db5c005)
- src/streamtubechannelapprover.h (aefe992)
- src/streamtubechannelapprover.cpp (2a99670)
- src/textchannelapprover.cpp (0e06a01)
- src/tubechannelapprover.h (PRE-CREATION)
- src/tubechannelapprover.cpp (PRE-CREATION)
View Diff
|