'Re: Review Request 108506: Simplify a change I made to ChannelContactsModel'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Re: Review Request 108506: Simplify a change I made to ChannelContactsModel
From:       "Commit Hook" <null () kde ! org>
Date:       2013-01-22 14:45:29
Message-ID: 20130122144529.23994.53227 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108506/#review25984
-----------------------------------------------------------

This review has been submitted with commit 1d10cb760d8ae7f1fb34c98c3a6820ffba7c6726 \
by David Edmundson to branch master.

- Commit Hook

On Jan. 20, 2013, 1:58 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108506/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2013, 1:58 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix some stupid code I made two days ago which keeps a hash that Tp::TextChannelPtr \
> already has. 
> 
> Diffs
> -----
> 
> lib/channel-contact-model.h 031a98cef050790f345b7f48a60b9005c54dfcd2 
> lib/channel-contact-model.cpp da377662d3ac0742aab5a5df099eea06918db3e0 
> 
> Diff: http://git.reviewboard.kde.org/r/108506/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108506/">http://git.reviewboard.kde.org/r/108506/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 1d10cb760d8ae7f1fb34c98c3a6820ffba7c6726 by David Edmundson to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On January 20th, 2013, 1:58 p.m. UTC, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Jan. 20, 2013, 1:58 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix some stupid code I made two days ago which keeps a hash that \
Tp::TextChannelPtr already has.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>lib/channel-contact-model.h <span style="color: \
grey">(031a98cef050790f345b7f48a60b9005c54dfcd2)</span></li>

 <li>lib/channel-contact-model.cpp <span style="color: \
grey">(da377662d3ac0742aab5a5df099eea06918db3e0)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108506/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 