[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Re: Ship it? Who should be doing code reviews
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2013-01-20 23:06:10
Message-ID: CACcA1RrXNfvi+h9xWUJwZ5W3pCunUvfn-ghKguoQNf5yPokq3Q () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sun, Jan 20, 2013 at 1:24 PM, David Edmundson <david@davidedmundson.co.uk
> wrote:

> This is in response to a comment I saw on reviewboard last night, but
> I want to reply to the whole mailing list.
>
> If you've ever committed code on KTp, you should be helping do reviews
> and you should click "ship it!" if you understand the code and agree
> with the patch. I don't want people to think "I'm not the manager, I
> shouldn't be clicking Ship it". In KTp, all developers are equal, and
> should all have equal powers & responsibility.
>
> If I write a patch, and I want a specific person to review it, I'll
> simply wait for a second "ship it" from someone else. If you review
> someone elses code and click ship it! and I disagree, I'll simply
> comment afterwards. Even if the code gets commmitted, I'll still see
> the review and can fix it afterwards.
>
> David.
> _______________________________________________
> KDE-Telepathy mailing list
> KDE-Telepathy@kde.org
> https://mail.kde.org/mailman/listinfo/kde-telepathy
>

I get the message. :P

Thanks!
Aleix

[Attachment #5 (text/html)]

On Sun, Jan 20, 2013 at 1:24 PM, David Edmundson <span dir="ltr">&lt;<a \
href="mailto:david@davidedmundson.co.uk" \
target="_blank">david@davidedmundson.co.uk</a>&gt;</span> wrote:<br><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">

This is in response to a comment I saw on reviewboard last night, but<br>
I want to reply to the whole mailing list.<br>
<br>
If you&#39;ve ever committed code on KTp, you should be helping do reviews<br>
and you should click &quot;ship it!&quot; if you understand the code and agree<br>
with the patch. I don&#39;t want people to think &quot;I&#39;m not the manager, I<br>
shouldn&#39;t be clicking Ship it&quot;. In KTp, all developers are equal, and<br>
should all have equal powers &amp; responsibility.<br>
<br>
If I write a patch, and I want a specific person to review it, I&#39;ll<br>
simply wait for a second &quot;ship it&quot; from someone else. If you review<br>
someone elses code and click ship it! and I disagree, I&#39;ll simply<br>
comment afterwards. Even if the code gets commmitted, I&#39;ll still see<br>
the review and can fix it afterwards.<br>
<br>
David.<br>
_______________________________________________<br>
KDE-Telepathy mailing list<br>
<a href="mailto:KDE-Telepathy@kde.org">KDE-Telepathy@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-telepathy" \
target="_blank">https://mail.kde.org/mailman/listinfo/kde-telepathy</a><br> \
</blockquote></div><br><div>I get the message. \
:P</div><div><br></div><div>Thanks!</div><div>Aleix</div>



_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy


[prev in list] [next in list] [prev in thread] [next in thread]