[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 108499: Make ContactList applet an PopupApplet
From: "Commit Hook" <null () kde ! org>
Date: 2013-01-20 16:00:30
Message-ID: 20130120160030.27507.18647 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108499/#review25850
-----------------------------------------------------------
This review has been submitted with commit 8b0888aa0d2a8be5beb23b097f4c6506e93379e7 \
by Dan Vrátil to branch master.
- Commit Hook
On Jan. 20, 2013, 2:23 a.m., Dan Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108499/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2013, 2:23 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Makes ContactList applet a PopupApplet so that it can be placed into a panel.
>
> When the panel is big enough (specified by minimumHeight and minimumWidth \
> properties of the applet), it automatically shows the whole contact list.
>
> This addresses bug 301323.
> http://bugs.kde.org/show_bug.cgi?id=301323
>
>
> Diffs
> -----
>
> contactlist/org.kde.ktp-contactlist/contents/ui/main.qml e974191
> contactlist/org.kde.ktp-contactlist/metadata.desktop 9c38d59
>
> Diff: http://git.reviewboard.kde.org/r/108499/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/cl-panel-vertical.png
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/cl-panel-vertical-wide.png
>
>
> Thanks,
>
> Dan Vrátil
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108499/">http://git.reviewboard.kde.org/r/108499/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 8b0888aa0d2a8be5beb23b097f4c6506e93379e7 by Dan Vrátil to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On January 20th, 2013, 2:23 a.m. UTC, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2013, 2:23 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Makes ContactList applet a PopupApplet so that it can be placed into a \
panel.
When the panel is big enough (specified by minimumHeight and minimumWidth properties \
of the applet), it automatically shows the whole contact list. </pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=301323">301323</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>contactlist/org.kde.ktp-contactlist/contents/ui/main.qml <span style="color: \
grey">(e974191)</span></li>
<li>contactlist/org.kde.ktp-contactlist/metadata.desktop <span style="color: \
grey">(9c38d59)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108499/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/cl-panel-vertical.png">cl-panel-vertical.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/cl-panel-vertical-wide.png">cl-panel-vertical-wide.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic