'Review Request: Fix on Bug 295106 (The reset button in kcm_ktp_chat_apparence is not working)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Review Request: Fix on Bug 295106 (The reset button in kcm_ktp_chat_apparence is not working)
From:       "Nick Lou" <nicklkde () ymail ! com>
Date:       2012-07-20 22:45:18
Message-ID: 20120720224518.9824.23309 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105642/
-----------------------------------------------------------

Review request for Telepathy, Daniele Elmo Domenichelli and George Kiagiadakis.

Description
-------

Kde-telepathy 0.4.0, text-ui.
Bug 295106 (The reset button in kcm_ktp_chat_apparence is not working)
I fixed this bug, it seems working properly to me now.Please note that default button \
had the same problem, fixed that too.

I am sending the diff and the whole file.

This addresses bugs 295106, Bug, button, in, kcm_ktp_chat_apparence, not_working, and \
reset.  http://bugs.kde.org/show_bug.cgi?id=295106
    http://bugs.kde.org/show_bug.cgi?id=Bug
    http://bugs.kde.org/show_bug.cgi?id=button
    http://bugs.kde.org/show_bug.cgi?id=in
    http://bugs.kde.org/show_bug.cgi?id=kcm_ktp_chat_apparence
    http://bugs.kde.org/show_bug.cgi?id=not_working
    http://bugs.kde.org/show_bug.cgi?id=reset

Diffs
-----

Diff: http://git.reviewboard.kde.org/r/105642/diff/

Testing
-------

On theme config settings:
1)Applying a theme.
2)Pressing default button //action: setting options to default values.
3)Pressing reset button //action:setting options to applied values
4)Repeating this procedure several times.

Thanks,

Nick Lou

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105642/">http://git.reviewboard.kde.org/r/105642/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Telepathy, Daniele Elmo Domenichelli and George \
Kiagiadakis.</div> <div>By Nick Lou.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Kde-telepathy 0.4.0, text-ui. Bug 295106 (The reset button in \
kcm_ktp_chat_apparence is not working) I fixed this bug, it seems working properly to \
me now.Please note that default button had the same problem, fixed that too.

I am sending the diff and the whole file.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">On theme config settings: 1)Applying a theme.
2)Pressing default button //action: setting options to default values.
3)Pressing reset button //action:setting options to applied values
4)Repeating this procedure several times.</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=295106">295106</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=Bug">Bug</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=button">button</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=in">in</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=kcm_ktp_chat_apparence">kcm_ktp_chat_apparence</a>, \

 <a href="http://bugs.kde.org/show_bug.cgi?id=not_working">not_working</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=reset">reset</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105642/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 