'Re: Review Request: [ktp-log-viewer] Does not select group headings in EntityView'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Re: Review Request: [ktp-log-viewer] Does not select group headings in EntityView
From:       "Commit Hook" <null () kde ! org>
Date:       2012-07-13 17:36:15
Message-ID: 20120713173615.32233.55610 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105557/#review15815
-----------------------------------------------------------

This review has been submitted with commit 40eeda43d3c1e2d662c793356fbca08bade23e64 \
by Dan Vrátil to branch master.

- Commit Hook

On July 13, 2012, 5:27 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105557/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 5:27 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Very distant future plan/idea: it would be cool if selecting the account would \
> display some statistics like total number or logged chat sessions, message count, \
> average message count per chat session, total size of the logs etc. 
> 
> This addresses bug 303418.
> http://bugs.kde.org/show_bug.cgi?id=303418
> 
> 
> Diffs
> -----
> 
> logviewer/entity-model.h 344a794 
> logviewer/entity-model.cpp 23fac74 
> logviewer/log-viewer.h 04820fd 
> logviewer/log-viewer.cpp 6007f92 
> 
> Diff: http://git.reviewboard.kde.org/r/105557/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105557/">http://git.reviewboard.kde.org/r/105557/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 40eeda43d3c1e2d662c793356fbca08bade23e64 by Dan Vrátil to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On July 13th, 2012, 5:27 p.m., Dan Vratil wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By Dan Vratil.</div>

<p style="color: grey;"><i>Updated July 13, 2012, 5:27 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Very distant future plan/idea: it would be cool if selecting the account \
would display some statistics like total number or logged chat sessions, message \
count, average message count per chat session, total size of the logs etc.</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=303418">303418</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>logviewer/entity-model.h <span style="color: grey">(344a794)</span></li>

 <li>logviewer/entity-model.cpp <span style="color: grey">(23fac74)</span></li>

 <li>logviewer/log-viewer.h <span style="color: grey">(04820fd)</span></li>

 <li>logviewer/log-viewer.cpp <span style="color: grey">(6007f92)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105557/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 