[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Review Request: Minimalistic delegate (aka Lydia Pintscher mode)
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2012-07-08 14:51:32
Message-ID: 20120708145132.27429.80598 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105477/
-----------------------------------------------------------
Review request for Telepathy.
Description
-------
This implements even smaller delegate for people who like to see looooots of contacts \
at once. I'm just not sure about using smallestReadableFont(), see screenshot - the \
generalFont() (on right) is good enough imho. Also the sizeHint() still should \
probably take font size into account.
This addresses bug 303051.
http://bugs.kde.org/show_bug.cgi?id=303051
Diffs
-----
contact-delegate-compact.h 7fa2907
contact-delegate-compact.cpp 91f3497
contact-list-widget.h 724050d
contact-list-widget.cpp ee65883
main-widget.cpp 2baebe3
Diff: http://git.reviewboard.kde.org/r/105477/diff/
Testing
-------
Done.
Screenshots
-----------
Mini delegate, smallest font on left, general on right
http://git.reviewboard.kde.org/r/105477/s/618/
Thanks,
Martin Klapetek
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105477/">http://git.reviewboard.kde.org/r/105477/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Martin Klapetek.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This implements even smaller delegate for people who like to see \
looooots of contacts at once. I'm just not sure about using \
smallestReadableFont(), see screenshot - the generalFont() (on right) is good enough \
imho. Also the sizeHint() still should probably take font size into account.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Done.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=303051">303051</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>contact-delegate-compact.h <span style="color: grey">(7fa2907)</span></li>
<li>contact-delegate-compact.cpp <span style="color: grey">(91f3497)</span></li>
<li>contact-list-widget.h <span style="color: grey">(724050d)</span></li>
<li>contact-list-widget.cpp <span style="color: grey">(ee65883)</span></li>
<li>main-widget.cpp <span style="color: grey">(2baebe3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105477/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105477/s/618/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/08/cl_mini_03_400x100.png" \
style="border: 1px black solid;" alt="Mini delegate, smallest font on left, general \
on right" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic