'Re: Review Request: Only show valid options in contact context menu'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Re: Review Request: Only show valid options in contact context menu
From:       "Alex Fiestas" <alex () eyeos ! org>
Date:       2012-06-25 10:35:01
Message-ID: 20120625103501.28424.58417 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105344/#review15107
-----------------------------------------------------------

Can't tell what this patch does exactly (screenshots !) but generally acros=
s all KDE software people usually grey out entries instead of removing them=
. =

Maybe until there is a new standard ktp should do the same?

- Alex Fiestas

On June 24, 2012, 11:14 p.m., David Edmundson wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105344/
> -----------------------------------------------------------
> =

> (Updated June 24, 2012, 11:14 p.m.)
> =

> =

> Review request for Telepathy.
> =

> =

> Description
> -------
> =

> Check if contact manager supports blocking contact before adding the item.
> Also only show re-request/resend authentication if it actually is a valid=
 option.
> =

> =

> Diffs
> -----
> =

>   context-menu.cpp 988f321 =

>   dialogs/remove-contact-dialog.cpp 7b5fa1f =

> =

> Diff: http://git.reviewboard.kde.org/r/105344/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> David Edmundson
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105344/">http://git.reviewboard.kde.org/r/105344/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can&#39;t tell what this \
patch does exactly (screenshots !) but generally across all KDE software people \
usually grey out entries instead of removing them.  Maybe until there is a new \
standard ktp should do the same?</pre>  <br />

<p>- Alex</p>

<br />
<p>On June 24th, 2012, 11:14 p.m., David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated June 24, 2012, 11:14 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Check if contact manager supports blocking contact before adding the \
item. Also only show re-request/resend authentication if it actually is a valid \
option.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>context-menu.cpp <span style="color: grey">(988f321)</span></li>

 <li>dialogs/remove-contact-dialog.cpp <span style="color: \
grey">(7b5fa1f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105344/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 