[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Re: KTp Contact runner
From:       Dario Freddi <drf54321 () gmail ! com>
Date:       2012-03-12 10:38:07
Message-ID: CAFFVnfPGhjgb0zMFBP5Au6GKN=TVhOOZi9k+uowVGQwC0X5rYQ () mail ! gmail ! com
[Download RAW message or body]

2012/3/12 Martin Klapetek <martin.klapetek@gmail.com>:
> Thanks a lot for this, great job!
>
> My review points:
>
> 1) We no longer use=A0"org.freedesktop.Telepathy.Client.KDE.TextUi" as the
> handler identifier, use "org.freedesktop.Telepathy.Client.KTp.TextUi"
> instead, same for filetransfer - replace "KDE" with "KTp" (and watch out =
for
> the general capitalization, we use KTp, you use KTP sometimes) As for cal=
ls
> (audio/video) - we currently don't really support calls; while it's cool =
to
> have it ready, I'd comment it out for the time being.

Nitpick - we should expose these values through constants or such in
our public API, pretty much like tp-qt does. Magic strings in client
applications are definitely not desirable.

>
> 3) I also agree that keeping the whole model in memory all the time is
> probably unwanted. The models are pretty quick to load (try opening conta=
ct
> list while connected), so it could probably use lazy loading.

++

>
> Otherwise I'm happy to put it into the 0.4 release.

++, thanks!

>
> --
> Martin Klapetek | KDE=A0Developer
>
>
>
> On Sun, Mar 11, 2012 at 23:22, Dan Vratil <dan@progdan.cz> wrote:
>>
>> Hi,
>>
>> I've made a little Krunner plugin for starting chat with IM contacts and=
 I
>> think it would be nice to have it as part of the KTp framework together
>> with
>> the plasma applets.
>>
>> For now it's in my scratch repo, but I'd like to move it somewhere publi=
c,
>> best to the Telepathy project. I'm of course willing to maintain it ther=
e,
>> there's really not much work since it's really small and simple piece of
>> code.
>>
>> Before any action I'd like to get some feedback from you, because I first
>> saw
>> Telepathy API 48 hours ago, so there will be some place for improvements
>> :)
>>
>> Detailed description here:
>>
>> http://www.progdan.cz/2012/03/kde-telepathy-plugin-for-krunner
>>
>> and the repo is
>>
>> git://anongit.kde.org/scratch/dvratil/ktp-contact-runner.git
>>
>> Regards,
>> Dan Vratil
>>
>> --
>> Dan Vratil
>> www.progdan.cz | dan@progdan.cz | Jabber: progdan@jabber.cz
>> Fingerprint: 76C9 2F08 5D0D 6F9E 5AD4 2BFD 3A85 0307 F506 5B61
>> _______________________________________________
>> KDE-Telepathy mailing list
>> KDE-Telepathy@kde.org
>> https://mail.kde.org/mailman/listinfo/kde-telepathy
>>
>
>
> _______________________________________________
> KDE-Telepathy mailing list
> KDE-Telepathy@kde.org
> https://mail.kde.org/mailman/listinfo/kde-telepathy
>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]