[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request: Make the rename dialog modeless
From: "Daniele Elmo Domenichelli" <daniele.domenichelli () gmail ! com>
Date: 2011-12-19 11:46:58
Message-ID: 20111219114658.1675.47937 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103453/#review9074
-----------------------------------------------------------
This will conflict with my cumulative patch https://git.reviewboard.kde.org/r/103466 \
:P Anyway, let's get this in first, I will rebase mine later...
A few comments:
src/handle-incoming-file-transfer-channel-job.h
<http://git.reviewboard.kde.org/r/103453/#comment7504>
This method does not need to be started on a different thread (using QTimer) so \
it does not need to be a slot (in my patch I'm removing some more of those)
src/handle-incoming-file-transfer-channel-job.cpp
<http://git.reviewboard.kde.org/r/103453/#comment7508>
Please rename it __k__onRenameDialogFinished(), since I'm adding a \
__k__onResumeDialogFinished() in my patch
src/handle-incoming-file-transfer-channel-job.cpp
<http://git.reviewboard.kde.org/r/103453/#comment7505>
rename it setUri()
src/handle-incoming-file-transfer-channel-job.cpp
<http://git.reviewboard.kde.org/r/103453/#comment7503>
modal is false by default if you start it with show(), so this line is useless
src/handle-incoming-file-transfer-channel-job.cpp
<http://git.reviewboard.kde.org/r/103453/#comment7506>
just call setUri() here
src/handle-incoming-file-transfer-channel-job.cpp
<http://git.reviewboard.kde.org/r/103453/#comment7507>
same here
Bug 288559 is not fixed by this patch since the idea was to close the rename dialog \
when the ft is cancelled (even though at the moment I'm not sure if this is a very \
good idea). Anyway, don't close that bug with the commit.
Please fix these as soon as possible because I want to get my patch integrated before \
the feature freeze :D
- Daniele Elmo Domenichelli
On Dec. 18, 2011, 5:25 p.m., Dominik Cermak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103453/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2011, 5:25 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Make the rename dialog modeless so that filetransfer handler doesn't crash when \
> canceling the transfer through the notification while the dialog is open.
>
> This addresses bugs 283003 and 288559.
> http://bugs.kde.org/show_bug.cgi?id=283003
> http://bugs.kde.org/show_bug.cgi?id=288559
>
>
> Diffs
> -----
>
> src/handle-incoming-file-transfer-channel-job.h \
> 9cc7ad9023e11f002cdd4ed373059e38c754ae3b \
> src/handle-incoming-file-transfer-channel-job.cpp \
> 0821081d1dbf8948a070fba157c35c5ca26a4fe9
> Diff: http://git.reviewboard.kde.org/r/103453/diff/diff
>
>
> Testing
> -------
>
> Canceling the filetransfer through the notification while the rename dialog is open \
> doesn't crash filetransfer handler.
>
> Thanks,
>
> Dominik Cermak
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103453/">http://git.reviewboard.kde.org/r/103453/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This will conflict with \
my cumulative patch https://git.reviewboard.kde.org/r/103466 :P Anyway, let's get \
this in first, I will rebase mine later...
A few comments:</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103453/diff/1/?file=43829#file43829line50" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/handle-incoming-file-transfer-channel-job.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
HandleIncomingFileTransferChannelJob : public KTp::TelepathyBaseJob</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">50</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Q_PRIVATE_SLOT</span><span class="p">(</span><span \
class="n">d_func</span><span class="p">(),</span> <span class="kt">void</span> <span \
class="n">__k__SetUri</span><span class="p">())</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This method \
does not need to be started on a different thread (using QTimer) so it does not need \
to be a slot (in my patch I'm removing some more of those)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103453/diff/1/?file=43830#file43830line65" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/handle-incoming-file-transfer-channel-job.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
HandleIncomingFileTransferChannelJobPrivate : public \
KTp::TelepathyBaseJobPrivate</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">65</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="n">__k__onDialogFinished</span><span \
class="p">(</span><span class="kt">int</span> <span class="n">result</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please \
rename it __k__onRenameDialogFinished(), since I'm adding a \
__k__onResumeDialogFinished() in my patch</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103453/diff/1/?file=43830#file43830line66" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/handle-incoming-file-transfer-channel-job.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
HandleIncomingFileTransferChannelJobPrivate : public \
KTp::TelepathyBaseJobPrivate</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">66</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="n">__k__SetUri</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">rename it \
setUri()</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103453/diff/1/?file=43830#file43830line192" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/handle-incoming-file-transfer-channel-job.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
HandleIncomingFileTransferChannelJobPrivate::__k__start()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">188</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">renameDialog</span><span class="p">.</span><span class="n">data</span><span \
class="p">()</span><span class="o">-></span><span class="n"><span \
class="hl">exec</span></span><span class="p"><span \
class="hl">(</span>);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">192</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">renameDialog</span><span \
class="p">.</span><span class="n">data</span><span class="p">()</span><span \
class="o">-></span><span class="n"><span class="hl">setModal</span></span><span \
class="p"><span class="hl">(</span></span><span class="kc"><span \
class="hl">false</span></span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">modal is \
false by default if you start it with show(), so this line is useless</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103453/diff/1/?file=43830#file43830line198" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/handle-incoming-file-transfer-channel-job.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
HandleIncomingFileTransferChannelJobPrivate::__k__start()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">198</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QTimer</span><span class="o">::</span><span \
class="n">singleShot</span><span class="p">(</span><span class="mi">0</span><span \
class="p">,</span> <span class="n">q</span><span class="p">,</span> <span \
class="n">SLOT</span><span class="p">(</span><span class="n">__k__SetUri</span><span \
class="p">()));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">just call \
setUri() here</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103453/diff/1/?file=43830#file43830line240" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/handle-incoming-file-transfer-channel-job.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
HandleIncomingFileTransferChannelJobPrivate::__k__start()</pre></td> <td \
colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
HandleIncomingFileTransferChannelJobPrivate::__k__onDialogFinished(int \
result)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">240</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QTimer</span><span class="o">::</span><span \
class="n">singleShot</span><span class="p">(</span><span class="mi">0</span><span \
class="p">,</span> <span class="n">q</span><span class="p">,</span> <span \
class="n">SLOT</span><span class="p">(</span><span class="n">__k__SetUri</span><span \
class="p">()));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">same \
here</pre> </div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug 288559 is not fixed \
by this patch since the idea was to close the rename dialog when the ft is cancelled \
(even though at the moment I'm not sure if this is a very good idea). Anyway, \
don't close that bug with the commit.
Please fix these as soon as possible because I want to get my patch integrated before \
the feature freeze :D
</pre>
<p>- Daniele Elmo</p>
<br />
<p>On December 18th, 2011, 5:25 p.m., Dominik Cermak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dominik Cermak.</div>
<p style="color: grey;"><i>Updated Dec. 18, 2011, 5:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make the rename dialog modeless so that filetransfer handler doesn't \
crash when canceling the transfer through the notification while the dialog is \
open.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Canceling the filetransfer through the notification while the rename \
dialog is open doesn't crash filetransfer handler.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=283003">283003</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=288559">288559</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/handle-incoming-file-transfer-channel-job.h <span style="color: \
grey">(9cc7ad9023e11f002cdd4ed373059e38c754ae3b)</span></li>
<li>src/handle-incoming-file-transfer-channel-job.cpp <span style="color: \
grey">(0821081d1dbf8948a070fba157c35c5ca26a4fe9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103453/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic