'Review Request: More asynchronousness in the nepomuk service'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Review Request: More asynchronousness in the nepomuk service
From:       "George Goldberg" <grundleborg () googlemail ! com>
Date:       2011-08-10 16:20:21
Message-ID: 20110810162021.25550.21432 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102289/
-----------------------------------------------------------

Review request for Telepathy.

Summary
-------

This patch makes the use of the queryservice in the NepomukStorage fully as=
ynchronous.

Diffs
-----

  abstract-storage.h 24b47b5416f76571cb4b2e0299756b355ded0e74 =

  controller.h 4fb89a29b3c7bed55f4227c9b3f001da81e5e5e8 =

  controller.cpp 3ab13920f681988caaf50dfba3ad7be9350a1df4 =

  nepomuk-storage.h 8077c56fed63204d33aadeb93f2b38635c2c4c37 =

  nepomuk-storage.cpp 51382fcfbef976ebc2adaa7c07f73e94983a2860 =

  service.h 78127a518837b283c4e1f37f131b9dfb3b61f0d4 =

  service.cpp 4b65ec0b1fef99427f4f037fe69a9d6254d2b707 =

  tests/controller-test.h be2f3b9c43b68b650df2c6ff8d7137d1daf9428f =

  tests/controller-test.cpp 68186c35c9bfdd6a3e10250ccdc66eaf8f374c73 =

  tests/storage-test.cpp c1771f17a071456eea59908427ab7db28f7c7e7d =

Diff: http://git.reviewboard.kde.org/r/102289/diff

Testing
-------

Updated unit-tests all pass.

Thanks,

George

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102289/">http://git.reviewboard.kde.org/r/102289/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By George Goldberg.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch makes the use of the queryservice in the NepomukStorage fully \
asynchronous.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Updated unit-tests all pass.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>abstract-storage.h <span style="color: \
grey">(24b47b5416f76571cb4b2e0299756b355ded0e74)</span></li>

 <li>controller.h <span style="color: \
grey">(4fb89a29b3c7bed55f4227c9b3f001da81e5e5e8)</span></li>

 <li>controller.cpp <span style="color: \
grey">(3ab13920f681988caaf50dfba3ad7be9350a1df4)</span></li>

 <li>nepomuk-storage.h <span style="color: \
grey">(8077c56fed63204d33aadeb93f2b38635c2c4c37)</span></li>

 <li>nepomuk-storage.cpp <span style="color: \
grey">(51382fcfbef976ebc2adaa7c07f73e94983a2860)</span></li>

 <li>service.h <span style="color: \
grey">(78127a518837b283c4e1f37f131b9dfb3b61f0d4)</span></li>

 <li>service.cpp <span style="color: \
grey">(4b65ec0b1fef99427f4f037fe69a9d6254d2b707)</span></li>

 <li>tests/controller-test.h <span style="color: \
grey">(be2f3b9c43b68b650df2c6ff8d7137d1daf9428f)</span></li>

 <li>tests/controller-test.cpp <span style="color: \
grey">(68186c35c9bfdd6a3e10250ccdc66eaf8f374c73)</span></li>

 <li>tests/storage-test.cpp <span style="color: \
grey">(c1771f17a071456eea59908427ab7db28f7c7e7d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102289/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 