'Review Request: Make Contactable Objects implement the Contactable'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Review Request: Make Contactable Objects implement the Contactable
From:       "George Goldberg" <grundleborg () googlemail ! com>
Date:       2011-08-07 15:11:16
Message-ID: 20110807151116.21677.80182 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102247/
-----------------------------------------------------------

Review request for Telepathy and Dario Freddi.

Summary
-------

The patch I meant to submit last week - this actually implements the Contac=
table interface for all our Contactable classes. It doesn't do any complica=
ted logic yet when dealing with Person or PersonSet. That's something we ne=
ed to put a bit more thought into, but for now just a basic approach is goo=
d enough just to get things moving.

Diffs
-----

  src/core/contact-set.h 56cef034fcf990bb1a6d4c6f0e7fb117531de7e2 =

  src/core/contact-set.cpp b47465b974358a0b55630ac66c7c1e6688e50c02 =

  src/core/contact.h 23cb0a9100cea45e0d80653c3ded8b3630544713 =

  src/core/contact.cpp 19172f02ee22c0489dfd6a84a75ed7026227a2e5 =

  src/core/contactable.h 8266d9a3b5cc9e49bde6db7ac2fb7e386734e19e =

  src/core/contactable.cpp ec01d440c73d26adcdb851a6997dea59af00d007 =

  src/core/person-set.h ab52d367698c1e94d6c5442dbe538b8250bfe3db =

  src/core/person-set.cpp 4d4a945e6f3e15b0bd029e924b9269546cb158a7 =

  src/core/person.h 7a262dac126f24e28266e723f17ea8221bf7d623 =

  src/core/person.cpp 8c0b622490819c3acc2d830dbbdfca61fc120d95 =

Diff: http://git.reviewboard.kde.org/r/102247/diff

Testing
-------

Thanks,

George

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102247/">http://git.reviewboard.kde.org/r/102247/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Telepathy and Dario Freddi.</div>
<div>By George Goldberg.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch I meant to submit last week - this actually implements the \
Contactable interface for all our Contactable classes. It doesn&#39;t do any \
complicated logic yet when dealing with Person or PersonSet. That&#39;s something we \
need to put a bit more thought into, but for now just a basic approach is good enough \
just to get things moving.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/contact-set.h <span style="color: \
grey">(56cef034fcf990bb1a6d4c6f0e7fb117531de7e2)</span></li>

 <li>src/core/contact-set.cpp <span style="color: \
grey">(b47465b974358a0b55630ac66c7c1e6688e50c02)</span></li>

 <li>src/core/contact.h <span style="color: \
grey">(23cb0a9100cea45e0d80653c3ded8b3630544713)</span></li>

 <li>src/core/contact.cpp <span style="color: \
grey">(19172f02ee22c0489dfd6a84a75ed7026227a2e5)</span></li>

 <li>src/core/contactable.h <span style="color: \
grey">(8266d9a3b5cc9e49bde6db7ac2fb7e386734e19e)</span></li>

 <li>src/core/contactable.cpp <span style="color: \
grey">(ec01d440c73d26adcdb851a6997dea59af00d007)</span></li>

 <li>src/core/person-set.h <span style="color: \
grey">(ab52d367698c1e94d6c5442dbe538b8250bfe3db)</span></li>

 <li>src/core/person-set.cpp <span style="color: \
grey">(4d4a945e6f3e15b0bd029e924b9269546cb158a7)</span></li>

 <li>src/core/person.h <span style="color: \
grey">(7a262dac126f24e28266e723f17ea8221bf7d623)</span></li>

 <li>src/core/person.cpp <span style="color: \
grey">(8c0b622490819c3acc2d830dbbdfca61fc120d95)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102247/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 