[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request: Fix crash caused by nested event-loops
From: "George Goldberg" <grundleborg () googlemail ! com>
Date: 2011-07-29 18:45:50
Message-ID: 20110729184550.2145.35861 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 29, 2011, 6:12 p.m., Dario Freddi wrote:
> > Looks good - of course in the long-term it would be great to use async =
queries.
I totally agree that we want async queries, but that requires slightly more=
substantial changes, which I'm saving to do at the same time as the datama=
nagement service API port of the NepomukStorage class.
- George
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102139/#review5221
-----------------------------------------------------------
On July 29, 2011, 2:20 p.m., George Goldberg wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102139/
> -----------------------------------------------------------
> =
> (Updated July 29, 2011, 2:20 p.m.)
> =
> =
> Review request for Telepathy.
> =
> =
> Summary
> -------
> =
> This is not a full asyncification of the nepomuk service just yet - I'm d=
oing it a bit at a time. However, the changes in this patch improve perform=
ance by only doing the query for accounts and contacts once, rather than ea=
ch time and account and contact is constructed. They also improve performan=
ce by only writing changes to Nepomuk when the before is actually different=
to the after.
> =
> Coincidentally, this also fixes the problem where telepathy objects can p=
rocess events when the Nepomuk query service nested event loop runs.
> =
> =
> Diffs
> -----
> =
> nepomuk-storage.cpp 92780648c1624e72c8575b936de57e5447e1d793 =
> tests/storage-test.cpp ed3d35c3c8720e6b01056f0407bc682c52eee6fd =
> =
> Diff: http://git.reviewboard.kde.org/r/102139/diff
> =
> =
> Testing
> -------
> =
> Unit tests still pass (with appropriate modification).
> =
> =
> Thanks,
> =
> George
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102139/">http://git.reviewboard.kde.org/r/102139/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 29th, 2011, 6:12 p.m., <b>Dario Freddi</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good \
- of course in the long-term it would be great to use async queries.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I totally agree that we \
want async queries, but that requires slightly more substantial changes, which \
I'm saving to do at the same time as the datamanagement service API port of the \
NepomukStorage class.</pre> <br />
<p>- George</p>
<br />
<p>On July 29th, 2011, 2:20 p.m., George Goldberg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By George Goldberg.</div>
<p style="color: grey;"><i>Updated July 29, 2011, 2:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is not a full asyncification of the nepomuk service just yet - \
I'm doing it a bit at a time. However, the changes in this patch improve \
performance by only doing the query for accounts and contacts once, rather than each \
time and account and contact is constructed. They also improve performance by only \
writing changes to Nepomuk when the before is actually different to the after.
Coincidentally, this also fixes the problem where telepathy objects can process \
events when the Nepomuk query service nested event loop runs.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Unit tests still pass (with appropriate modification).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk-storage.cpp <span style="color: \
grey">(92780648c1624e72c8575b936de57e5447e1d793)</span></li>
<li>tests/storage-test.cpp <span style="color: \
grey">(ed3d35c3c8720e6b01056f0407bc682c52eee6fd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102139/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic